Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config(dumpling): update dumpling integration test requirements #394

Merged
merged 1 commit into from
Aug 6, 2021
Merged

config(dumpling): update dumpling integration test requirements #394

merged 1 commit into from
Aug 6, 2021

Conversation

lichunzhu
Copy link
Contributor

dumpling has updated the integration tests requirements in pingcap/dumpling#325

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 6, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Aug 6, 2021
@ti-chi-bot
Copy link
Member

Hi @lichunzhu. Thanks for your PR.

I'm waiting for a ti-community-infra member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot requested a review from Mini256 August 6, 2021 03:57
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 6, 2021
@lichunzhu lichunzhu changed the title update dumpling integration test requirements config(dumpling): update dumpling integration test requirements Aug 6, 2021
Rustin170506
Rustin170506 approved these changes Aug 6, 2021
View reviewed changes
Copy link
Contributor

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. status/LGT1 Indicates that a PR has LGTM 1. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Aug 6, 2021
@Rustin170506
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1c58715

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 6, 2021
@ti-chi-bot ti-chi-bot merged commit 78a6638 into ti-community-infra:main Aug 6, 2021
@ti-chi-bot
Copy link
Member

@lichunzhu: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/config/config.yaml

In response to this:

dumpling has updated the integration tests requirements in pingcap/dumpling#325

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lichunzhu lichunzhu deleted the updateDumpling branch August 6, 2021 06:22
@lichunzhu lichunzhu mentioned this pull request Aug 10, 2021
Merged
ti-chi-bot pushed a commit that referenced this pull request Aug 10, 2021
@lichunzhu
config(dumpling): update dumpling integration test requirements for r…
e98cc25 
…elease branches (#397)

extension of #394
The tests for release branches are not updated yet and some PRs are blocked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@Mini256 Mini256 Awaiting requested review from Mini256

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. ok-to-test Indicates a PR is ready to be tested. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lichunzhu @ti-chi-bot @Rustin170506