-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CBG trends display selections #363
Conversation
Depends on: tidepool-org/viz#36 |
ping @jebeck for review (or feel free to pass to next available person) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there are tests that should be updated...?
@jebeck - I added tests for the tracking middleware as none previously existed. I think most of the rest of the changes are relying on having unit tests in the |
Tests on |
@jebeck - I think that's all the tests that needed updating/creating. This should be good for review again. |
Ditto here with another update from master because of the late merge of #368 |
Thanks for the add of the totally missing tracking middleware tests! |
Conflicts: package.json
Conflicts: package.json
…-com Migrate Travis CI from travis-ci.org to travis-ci.com
Use the new display toggles from
viz
and track metrics.