Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBG trends display selections #363

Merged
merged 23 commits into from
Dec 15, 2016
Merged

CBG trends display selections #363

merged 23 commits into from
Dec 15, 2016

Conversation

krystophv
Copy link
Member

Use the new display toggles from viz and track metrics.

@krystophv
Copy link
Member Author

@krystophv krystophv changed the title [WIP] CBG trends display selections CBG trends display selections Dec 5, 2016
@krystophv
Copy link
Member Author

Depends on: tidepool-org/viz#36

@krystophv
Copy link
Member Author

ping @jebeck for review (or feel free to pass to next available person)

Copy link
Contributor

@jebeck jebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there are tests that should be updated...?

@krystophv
Copy link
Member Author

@jebeck - I added tests for the tracking middleware as none previously existed. I think most of the rest of the changes are relying on having unit tests in the viz repo. I don't seem to be able to find any existing sets of tests that need updating. If you think it'd be a good opportunity to add in tests for the Footer or Modal components (which I don't think we have right now) then I can look into those.

@jebeck
Copy link
Contributor

jebeck commented Dec 6, 2016

Tests on Footer would be good with the added complexity. Fine to leave Modal w/o tests. Thanks @krystophv!

@krystophv
Copy link
Member Author

@jebeck - I think that's all the tests that needed updating/creating. This should be good for review again.

@jebeck
Copy link
Contributor

jebeck commented Dec 9, 2016

Ditto here with another update from master because of the late merge of #368

@jebeck
Copy link
Contributor

jebeck commented Dec 9, 2016

Thanks for the add of the totally missing tracking middleware tests!

@jebeck jebeck mentioned this pull request Dec 12, 2016
@krystophv krystophv merged commit e5ff4e1 into master Dec 15, 2016
@krystophv krystophv deleted the krystophv/cgm-checkbox branch December 15, 2016 21:08
yvon-dblg referenced this pull request in mdblp/blip Dec 1, 2020
…-com

Migrate Travis CI from travis-ci.org to travis-ci.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants