Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did it @krystophv!!! 🎉 🎊 🎉
We just weren't using webpack right /o\
This PR also contains the addition of the React Perf addon in dev (attached to
window
so you can use in the console, as described e.g., here: http://benchling.engineering/performance-engineering-with-react/). Sticking it in the redux dev mode<Root />
component seemed like the easiest way (to me) to keep it out of prod, but LMK if you can think of a cleaner way.@hntrdglss for context: @krystophv noticed a while ago that we were clearly still using the dev build of React in production because propTypes validation shows up all over any perf profiles...