Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test on logging for racing with survival models #138

Closed
hfrick opened this issue Nov 16, 2023 · 3 comments
Closed

Add test on logging for racing with survival models #138

hfrick opened this issue Nov 16, 2023 · 3 comments
Assignees
@topepo

Comments

@hfrick
Copy link
Member

hfrick commented Nov 16, 2023

The issue mentioned in this comment has been closed tidymodels/finetune#81

extratests/tests/testthat/test-survival-tune-race.R

Lines 404 to 406 in 1531442

# TODO add a test for checking the evaluation time in this message:
# https://github.com/tidymodels/finetune/issues/81
expect_true(any(grepl("Racing will minimize the brier_survival metric", aov_dyn_output)))

topepo pushed a commit that referenced this issue Jan 11, 2024
test for #138 and tidymodels/finetune#81
b6ee7a0
@topepo topepo self-assigned this Jan 11, 2024
topepo added a commit that referenced this issue Jan 12, 2024
@topepo @hfrick
collect_predictions() for survival models (#158)
e5ad42b 
* initial tests

* updates for tidymodels/tune#798

* SA test updates

* update tune version

* update bayesian opt tests

* update racing unit tests

* update tune version

* temporarily point to PR

* improve readability of reference object

* racing updates; also covers changes in tidymodels/finetune#90

* updated for changes in #804

* test for #138 and tidymodels/finetune#81

* PR tune#798 has been merged, new one to check with is tune#804

* updated for new tune version

* version bumps

* update with new tune warning wording

* changes for tidymodels/tune#806

* more updated snapshots

* mroe snapshot updates

* update censored bagging snapshot

* irreproducible results; see #160

---------

Co-authored-by: ‘topepo’ <‘mxkuhn@gmail.com’>
Co-authored-by: Hannah Frick <hannah@posit.co>
@topepo
Copy link
Member

topepo commented Jan 12, 2024

Closed by #158

Specifically these lines

@topepo topepo closed this as completed Jan 12, 2024
@hfrick
Copy link
Member Author

hfrick commented Jan 16, 2024

I read that code comment as "check that the evaluation time is mentioned" whereas the test checks that the metric is mentioned. Shall we reopen this issue or is that a misunderstanding?

@hfrick
Copy link
Member Author

hfrick commented Jan 16, 2024

Keeping this closed, Max produced this as a receipt 😛

extratests/tests/testthat/test-survival-tune_race_anova.R

Line 440 in 683ec31

expect_true(any(grepl("Racing will minimize the brier_survival metric at time 10", aov_mixed_output)))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@topepo topepo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@topepo @hfrick