Survival summarize predictions include tuning parameters and .iter #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfrick
reviewed
Jan 8, 2024
There was a problem hiding this comment.
I've left a whole bunch of comments on the corresponding test PR but those largely don't seem to stem from this PR. The one I would investigate before moving further with this PR is tidymodels/extratests#158 (comment)
Additionally, I don't think this actually closes #800 , I'm gonna edit the PR description to reflect that so that we don't accidentally close it.
Co-authored-by: Hannah Frick <hfrick@users.noreply.github.com>
topepo
added a commit
to tidymodels/extratests
that referenced
this pull request
Jan 12, 2024
* initial tests * updates for tidymodels/tune#798 * SA test updates * update tune version * update bayesian opt tests * update racing unit tests * update tune version * temporarily point to PR * improve readability of reference object * racing updates; also covers changes in tidymodels/finetune#90 * updated for changes in #804 * test for #138 and tidymodels/finetune#81 * PR tune#798 has been merged, new one to check with is tune#804 * updated for new tune version * version bumps * update with new tune warning wording * changes for tidymodels/tune#806 * more updated snapshots * mroe snapshot updates * update censored bagging snapshot * irreproducible results; see #160 --------- Co-authored-by: ‘topepo’ <‘mxkuhn@gmail.com’> Co-authored-by: Hannah Frick <hannah@posit.co>
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were some missing
.byarguments and the columns were left out of the results.Also reorders the columns of
collect_predictions()so thatstarts_with(".pred")columns are to the right (previously scattered, esp in survival results).Tests in extratests.