This repository has been archived by the owner on Sep 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Here is test result. input path
result
test
|
taichiH
force-pushed
the
add-pcd-hash-genarator
branch
from
November 30, 2021 02:47
f90be3f
to
dbe4dcb
Compare
This was referenced Nov 30, 2021
@taichiH The hashing will be executed twice If it is a file. Is that OK?
|
@isamu-takagi But I just changed my mind because it's necessary to generate hash in the same way on the application side for example fms, and it feels strange. Is it better to change the hash generation method for a single file? |
@taichiH I think it is easier to understand. |
isamu-takagi
reviewed
Dec 1, 2021
@isamu-takagi I fixed point you've reviewed. |
isamu-takagi
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update map_hash_generator to publish pcd map hash.
tier4/autoware_launch-old#142
https://github.com/tier4/autoware_api_msgs/pull/42
tier4/AutowareArchitectureProposal_api_msgs#1
Review Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks