Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity_planner): do not consider stop_line_margin when a stop line is defined at map in crosswalk module #141

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

tkimura4
Copy link
Collaborator

@tkimura4 tkimura4 commented Sep 28, 2022

Signed-off-by: tomoya.kimura tomoya.kimura@tier4.jp

Related Links

autowarefoundation#1978
(TIERIV Internal: https://star4.slack.com/archives/CEV8XMJBV/p1664358448041849?thread_ts=1664323130.934649&cid=CEV8XMJBV )

Description

autowarefoundation#1978

In crosswalk module, the parameter stop_line_distance should be considered only when the explicit stop_line is not defined in lanelet. But, in the current implementation, stop_line_distance is always considered. I fixed it.

Hotfix to beta/v0.5.2.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

… a stop line is defined at map in crosswalk module

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Copy link

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit 54da3fb into beta/v0.5.2 Sep 28, 2022
@tkimura4 tkimura4 deleted the hotfix/crosswalk_margin-v0.5.2 branch September 28, 2022 09:52
takayuki5168 pushed a commit that referenced this pull request Dec 22, 2022
… a stop line is defined at map in crosswalk module (#141)

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Feb 7, 2024
* docs(ansible): add manual installation steps

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>

* ci(pre-commit): autofix

* add one more line

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>

* fix wording

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>

* add cspell ignore

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>

* make links relative

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants