Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(velodyne_monitor): backport #1623 and #1744 from awf/autoware.universe #152

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented Oct 13, 2022

Description

backport two PRs

These are merged at https://github.com/tier4/autoware.universe/tree/v0.4.1

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta requested a review from s-azumi October 13, 2022 08:34
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.5.3@14bc000). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##             beta/v0.5.3    #152   +/-   ##
=============================================
  Coverage               ?   0.00%           
=============================================
  Files                  ?       2           
  Lines                  ?     121           
  Branches               ?       0           
=============================================
  Hits                   ?       0           
  Misses                 ?     121           
  Partials               ?       0           
Flag Coverage Δ
differential 0.00% <0.00%> (?)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@s-azumi s-azumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…ture (#1623)

* fix(velodyne_monitor): fix warning and error threshold of hot temperature

* doc: update README

* doc: fix typo

* doc: update README

* feat: add config file for each model

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* Update Readme.md

* Update Readme.md

* fix: typo

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
@h-ohta h-ohta merged commit 46989f0 into beta/v0.5.3 Oct 17, 2022
@h-ohta h-ohta deleted the backport/velodyne_monitor branch October 17, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants