feat(planing_evaluator): add dianostic_converter and modfied_goal_deviation #322

kosuke55 · 2023-03-16T04:11:50Z

Description

cherry-pick

Tests performed

base
- https://evaluation.tier4.jp/evaluation/reports/36e8c8a2-ed72-5bb5-9389-05168252f50c?project_id=prd_jt 1124/1457
this PR
- https://evaluation.tier4.jp/evaluation/reports/7d5955c9-3336-5a15-847b-18206817ab48?project_id=prd_jt 1125/1457
check that the modified goal deviation can be used in scenario test
- https://evaluation.tier4.jp/evaluation/reports/0dbb52df-f02c-56fe-90d8-f778b2b42ef1/tests/e7ba6ced-d365-5142-b792-a9f3e9c57ae7/0551a730-8186-5352-83ca-ef534d623970?project_id=prd_jt

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.
The PR has been properly tested.
The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.
The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

… output for scenario's condition (autowarefoundation#2514) * add original diagnostic_convertor Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add test Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix typo Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * delete file Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * change include Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * delete comments Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * made launch for converter Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * ci(pre-commit): autofix * ci(pre-commit): autofix * add diagnostic convertor in launch Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * ci(pre-commit): autofix * change debug from info Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * change arg name to launch diagnostic convertor * add planning_evaluator launcher in simulator.launch.xml Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix arg wrong setting Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * style(pre-commit): autofix * use simulation msg in tier4_autoware_msgs Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * style(pre-commit): autofix * fix README Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * style(pre-commit): autofix * refactoring Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * style(pre-commit): autofix * remove unnecessary dependency Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * remove unnecessary dependency Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * move folder Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * reformat Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * style(pre-commit): autofix * Update evaluator/diagnostic_converter/include/converter_node.hpp Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> * Update evaluator/diagnostic_converter/README.md Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> * Update evaluator/diagnostic_converter/src/converter_node.cpp Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> * Update evaluator/diagnostic_converter/test/test_converter_node.cpp Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> * define diagnostic_topics as parameter Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix include way Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix include way Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * delete ament_cmake_clang_format from package.xml Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix test_depend Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * Update evaluator/diagnostic_converter/test/test_converter_node.cpp Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> * style(pre-commit): autofix * Update launch/tier4_simulator_launch/launch/simulator.launch.xml Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Maxime CLEMENT <78338830+maxime-clem@users.noreply.github.com>

…tion#3053) * feat(planning_evaluator): add modified goal deviation Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * add abs Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * remove setModifiedGoal Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * use Point and rename func Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix func docs Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix and add tests Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

codecov-commenter · 2023-03-16T04:27:47Z

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.7.0-odaiba1@d9ffc5f). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@                  Coverage Diff                  @@
##             beta/v0.7.0-odaiba1    #322   +/-   ##
=====================================================
  Coverage                       ?   5.05%           
=====================================================
  Files                          ?     189           
  Lines                          ?   18871           
  Branches                       ?    8373           
=====================================================
  Hits                           ?     954           
  Misses                         ?   17240           
  Partials                       ?     677

Flag	Coverage Δ
differential	`5.05% <0.00%> (?)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

…ion#2602) * feat(behavior_path_planner): modified goal with uuid Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix typo Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix for top header Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * change to PoseWithUuidStamped Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

…utowarefoundation#2662) * feat(tier4_planning_rviz_plugin): visualize pose_stamped_with_uuid Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * Update common/tier4_planning_rviz_plugin/include/pose_stamped_with_uuid/display.hpp Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> * Update common/tier4_planning_rviz_plugin/src/pose_stamped_with_uuid/display.cpp Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> * rename to pose_with_uuid_stamped Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * add icon Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * change default size Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

…n#3095) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

tkimura4

LGTM

* feat(ansible): add ccache into docker image Signed-off-by: Berkay <berkay@leodrive.ai> * Update ansible/roles/ccache/meta/main.yaml Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Signed-off-by: Berkay <berkay@leodrive.ai> Co-authored-by: Berkay <berkay@leodrive.ai> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

kyoichi-sugahara and others added 2 commits March 16, 2023 11:12

kosuke55 requested review from maxime-clem, KeisukeShima, rej55, kyoichi-sugahara, mkuri, soblin, satoshi-ota, shmpwk, taikitanaka3, TakaHoribe, takayuki5168, TomohitoAndo, tkimura4, purewater0901 and zulfaqar-azmi-t4 as code owners March 16, 2023 04:11

kosuke55 marked this pull request as draft March 16, 2023 04:12

github-actions bot added documentation Improvements or additions to documentation evaluator launch planning labels Mar 16, 2023

tkimura4 removed request for mkuri, rej55, KeisukeShima, TakaHoribe, soblin, kyoichi-sugahara, shmpwk and satoshi-ota March 16, 2023 04:12

tkimura4 removed request for taikitanaka3 and maxime-clem March 16, 2023 04:12

kosuke55 changed the title ~~Feat/diagnostic converter 0.7~~ feat(planing_evaluator): add dianostic_converter and modfied_goal_deviation Mar 16, 2023

tkimura4 removed request for takayuki5168, TomohitoAndo, purewater0901 and zulfaqar-azmi-t4 March 16, 2023 04:12

kosuke55 and others added 3 commits March 16, 2023 15:22

feat(mission_planner): add random id to route (autowarefoundation#2746)

37919fe

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

github-actions bot added the common label Mar 16, 2023

fix(behavior_path_planner): reset modified goal id (autowarefoundatio…

5f7ca9f

…n#3095) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

kosuke55 marked this pull request as ready for review March 17, 2023 00:46

kosuke55 requested review from isamu-takagi, mitsudome-r and yukkysaito as code owners March 17, 2023 00:46

tkimura4 removed request for isamu-takagi, mitsudome-r and yukkysaito March 17, 2023 01:03

tkimura4 enabled auto-merge March 17, 2023 01:03

tkimura4 approved these changes Mar 17, 2023

View reviewed changes

tkimura4 merged commit f223a2e into beta/v0.7.0-odaiba1 Mar 17, 2023

tkimura4 deleted the feat/diagnostic_converter_0.7 branch March 17, 2023 01:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(planing_evaluator): add dianostic_converter and modfied_goal_deviation #322

feat(planing_evaluator): add dianostic_converter and modfied_goal_deviation #322

kosuke55 commented Mar 16, 2023 •

edited

Loading

codecov-commenter commented Mar 16, 2023 •

edited

Loading

tkimura4 left a comment

feat(planing_evaluator): add dianostic_converter and modfied_goal_deviation #322

feat(planing_evaluator): add dianostic_converter and modfied_goal_deviation #322

Conversation

kosuke55 commented Mar 16, 2023 • edited Loading

Description

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

codecov-commenter commented Mar 16, 2023 • edited Loading

Codecov Report

tkimura4 left a comment

Choose a reason for hiding this comment

kosuke55 commented Mar 16, 2023 •

edited

Loading

codecov-commenter commented Mar 16, 2023 •

edited

Loading