Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(elevation_map_loader): large size pointcloud map (backport #2571, #2885, #943) #337

Merged
merged 5 commits into from
Mar 31, 2023

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented Mar 24, 2023

Description

backport following PRs
autowarefoundation#943
autowarefoundation#2571

This PR occurs some build error for boost geometry.
We can't resolve it because it is system header, so I remove -Werror.
autowarefoundation#2885

Related Links

https://tier4.atlassian.net/browse/T4PB-25501
https://github.com/tier4/autoware_launch.x1.eve/pull/376

Tests Perfomed

See T4PB-25501

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Shin-kyoto and others added 2 commits March 24, 2023 13:32
…er (autowarefoundation#2571)

* feat: reduce memory usage of elevation_map_loader

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>

* chore: remove unnecessary comment

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>

* fix: modify variables' name

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>

Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
…efoundation#2885)

* use grid_map::PolygonIterator instead of grid_map::GridMapIterator

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* formatting

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* use use_lane_filter option

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* delete unused use-lane-filter option

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* change use_lane_filter to True, clarify the scope

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* change to use grid_map_utils::PolygonIterator

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* Add lane margin parameter

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* use boost geometry buffer to expand lanes

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* Change use_lane_filter param default to false

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

* update README

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>

---------

Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
@h-ohta h-ohta changed the title Backport/2885 feat(elevation_map_loader):large size pointcloud map Mar 24, 2023
@h-ohta h-ohta changed the title feat(elevation_map_loader):large size pointcloud map feat(elevation_map_loader):large size pointcloud map (backport #2571, #2885) Mar 24, 2023
* Add grid_map_utils pkg with faster implementation of PolygonIterator

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@h-ohta h-ohta changed the title feat(elevation_map_loader):large size pointcloud map (backport #2571, #2885) feat(elevation_map_loader):large size pointcloud map (backport #2571, #2885, #943) Mar 24, 2023
@h-ohta h-ohta changed the title feat(elevation_map_loader):large size pointcloud map (backport #2571, #2885, #943) feat(elevation_map_loader): large size pointcloud map (backport #2571, #2885, #943) Mar 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.3.15@da26100). Click here to learn what that means.
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@               Coverage Diff               @@
##             beta/v0.3.15     #337   +/-   ##
===============================================
  Coverage                ?   14.92%           
===============================================
  Files                   ?        6           
  Lines                   ?      516           
  Branches                ?      215           
===============================================
  Hits                    ?       77           
  Misses                  ?      240           
  Partials                ?      199           
Flag Coverage Δ
differential 14.92% <0.00%> (?)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yn-mrse
Copy link

yn-mrse commented Mar 31, 2023

@h-ohta
Only b6d361c is not mentioned in the PR description, so please specify it.

Copy link

@YoheiMishina YoheiMishina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-ohta h-ohta merged commit b20c054 into beta/v0.3.15 Mar 31, 2023
@h-ohta h-ohta deleted the backport/2885 branch March 31, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants