-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(elevation_map_loader): large size pointcloud map (backport #2571, #2885, #943) #337
Conversation
…er (autowarefoundation#2571) * feat: reduce memory usage of elevation_map_loader Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com> * chore: remove unnecessary comment Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com> * fix: modify variables' name Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com> Signed-off-by: Shin-kyoto <58775300+Shin-kyoto@users.noreply.github.com>
…efoundation#2885) * use grid_map::PolygonIterator instead of grid_map::GridMapIterator Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * formatting Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * use use_lane_filter option Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * delete unused use-lane-filter option Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * change use_lane_filter to True, clarify the scope Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * change to use grid_map_utils::PolygonIterator Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * Add lane margin parameter Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * use boost geometry buffer to expand lanes Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * Change use_lane_filter param default to false Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> * update README Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp> --------- Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
* Add grid_map_utils pkg with faster implementation of PolygonIterator Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## beta/v0.3.15 #337 +/- ##
===============================================
Coverage ? 14.92%
===============================================
Files ? 6
Lines ? 516
Branches ? 215
===============================================
Hits ? 77
Misses ? 240
Partials ? 199
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
backport following PRs
autowarefoundation#943
autowarefoundation#2571
This PR occurs some build error for boost geometry.
We can't resolve it because it is system header, so I remove
-Werror
.autowarefoundation#2885
Related Links
https://tier4.atlassian.net/browse/T4PB-25501
https://github.com/tier4/autoware_launch.x1.eve/pull/376
Tests Perfomed
See T4PB-25501
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.