[to #215] Add integration test for tikv-cdc #216
Conversation
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
================================================
+ Coverage 61.3078% 61.8555% +0.5476%
================================================
Files 170 170
Lines 13809 13829 +20
================================================
+ Hits 8466 8554 +88
+ Misses 4716 4630 -86
- Partials 627 645 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
|
@pingyu @haojinming PTAL~ |
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
| PWD=$(pwd) | ||
| if [ ! -f $binary ]; then | ||
| cd $CUR/../../utils/rawkv_data/ | ||
| GO111MODULE=on go build |
There was a problem hiding this comment.
Suggest to build by Makefile, to make build flags consistent.
| PWD=$(pwd) | ||
|
|
||
| cd $CUR/../../utils/rawkv_data | ||
| if [ ! -f ./rawkv_data ]; then |
There was a problem hiding this comment.
Suggest to build by Makefile, to make build flags consistent.
Then we don't need this script ? Add utils/rawkv_data to $PATH and use it directly.
There was a problem hiding this comment.
I use Makefile to build rawkv_data, but I don't remove this script that used to check if rawkv_data exist.
| @@ -219,15 +221,6 @@ tidb-server \ | |||
| --status=${UP_TIDB_STATUS} \ | |||
| --log-file "$OUT_DIR/tidb.log" & | |||
|
|
|||
| randomGenSocketsConf | |||
There was a problem hiding this comment.
Suggest to use tiup playground to start the cluster, which would be easier, as we don't need to maintain all the commands & ports here. We just concern ports of PD.
But in current version of tiup playground, the PD port of downstream cluster is random (as the default 2379 is occupied by upstream cluster), which caused it difficult to make automatic tests.
The good news is that the feature of specifying PD port will be released in a near version (v1.11.0, see pingcap/tiup#1931).
So I think we can consider change to tiup playground later after the new version is released.
There was a problem hiding this comment.
If use tiup playground, we can't add/remove cdc_server casually for next test case.
Signed-off-by: zeminzhou <zhouzemin@pingcap.com>
What problem does this PR solve?
Add integration test for tikv-cdc
Issue Number: close #215
Problem Description: TBD
TiKV-CDC needs integraion test
What is changed and how does it work?
Add integration test for tikv-cdc
Check List for Tests
This PR has been tested by at least one of the following methods: