Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tso: "split 0 2 2 2" generate duplicate keyspaces in the keyspace list of the group #6687

Closed
binshi-bing opened this issue Jun 26, 2023 · 1 comment · Fixed by #6689 or #6732
Closed

tso: "split 0 2 2 2" generate duplicate keyspaces in the keyspace list of the group #6687

binshi-bing opened this issue Jun 26, 2023 · 1 comment · Fixed by #6689 or #6732
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@binshi-bing
Copy link
Contributor

Enhancement Task

root@serverless-cluster-pd-0:/# ./pd-ctl keyspace-group split 0 2 2 2
Success!

{"id":2,"user-kind":"basic","members":[{"address":"http://pd-tso-server-0.tso-service.tidb-serverless.svc:2379","priority":200},{"address":"http://pd-tso-server-1.tso-service.tidb-serverless.svc:2379","priority":300}],"keyspaces":[2,2]}
@binshi-bing binshi-bing added the type/enhancement The issue or PR belongs to an enhancement. label Jun 26, 2023
@binshi-bing binshi-bing mentioned this issue Jun 27, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jun 27, 2023
@binshi-bing
Add split-range cmd and fix duplicate keyspaces (#6689)
317c1bc 
close #6687, close #6688

Add split-range cmd and fix duplicate keyspaces
    
    1. Add split-range cmd to support StartKeyspaceID and EndKeyspaceID parameters.
    2. Fix "split 0 2 2 2" generate duplicate keyspaces in the keyspace list of the group"

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
@binshi-bing
Copy link
Contributor Author

The fix was reverted by #6707 by mistake

@binshi-bing binshi-bing reopened this Jun 30, 2023
This was referenced Jun 30, 2023
Merged
Merged
@ti-chi-bot ti-chi-bot bot closed this as completed in #6732 Jul 1, 2023
ti-chi-bot bot pushed a commit that referenced this issue Jul 1, 2023
@binshi-bing
mcs, tso: fix split and split-range command bugs. (#6732)
53d5a92 
close #6687, close #6731

Fix split and split-range command bugs.

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
rleungx pushed a commit to rleungx/pd that referenced this issue Aug 2, 2023
@binshi-bing @rleungx
Add split-range cmd and fix duplicate keyspaces (tikv#6689)
d16069b 
close tikv#6687, close tikv#6688

Add split-range cmd and fix duplicate keyspaces
    
    1. Add split-range cmd to support StartKeyspaceID and EndKeyspaceID parameters.
    2. Fix "split 0 2 2 2" generate duplicate keyspaces in the keyspace list of the group"

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
rleungx pushed a commit to rleungx/pd that referenced this issue Aug 2, 2023
@binshi-bing @rleungx
mcs, tso: fix split and split-range command bugs. (tikv#6732)
c1a3775 
close tikv#6687, close tikv#6731

Fix split and split-range command bugs.

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
rleungx pushed a commit to rleungx/pd that referenced this issue Aug 2, 2023
@binshi-bing @rleungx
Add split-range cmd and fix duplicate keyspaces (tikv#6689)
cf01cfa 
close tikv#6687, close tikv#6688

Add split-range cmd and fix duplicate keyspaces
    
    1. Add split-range cmd to support StartKeyspaceID and EndKeyspaceID parameters.
    2. Fix "split 0 2 2 2" generate duplicate keyspaces in the keyspace list of the group"

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
rleungx pushed a commit to rleungx/pd that referenced this issue Aug 2, 2023
@binshi-bing @rleungx
mcs, tso: fix split and split-range command bugs. (tikv#6732)
578aeb1 
close tikv#6687, close tikv#6731

Fix split and split-range command bugs.

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
1 participant
@binshi-bing