Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs, tso: keyspace-group split-range can't split default keyspace group #6731

Closed
binshi-bing opened this issue Jun 30, 2023 · 0 comments · Fixed by #6732
Closed

mcs, tso: keyspace-group split-range can't split default keyspace group #6731

binshi-bing opened this issue Jun 30, 2023 · 0 comments · Fixed by #6732
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@binshi-bing
Copy link
Contributor

Enhancement Task

root@serverless-cluster-pd-0:/# ./pd-ctl keyspace-group split-range 0 2 1 5000
Failed! [500] "cannot modify default keyspace's state"

for _, keyspace := range old {
	**if keyspace == utils.DefaultKeyspaceID {
		return nil, nil, ErrModifyDefaultKeyspace
	}**
	if startKeyspaceID <= keyspace && keyspace <= endKeyspaceID {
		newSplit = append(newSplit, keyspace)
		newKeyspaceMap[keyspace] = struct{}{}
	}
}
@binshi-bing binshi-bing added the type/enhancement The issue or PR belongs to an enhancement. label Jun 30, 2023
@ti-chi-bot ti-chi-bot bot closed this as completed in #6732 Jul 1, 2023
ti-chi-bot bot pushed a commit that referenced this issue Jul 1, 2023
close #6687, close #6731

Fix split and split-range command bugs.

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
rleungx pushed a commit to rleungx/pd that referenced this issue Aug 2, 2023
close tikv#6687, close tikv#6731

Fix split and split-range command bugs.

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
rleungx pushed a commit to rleungx/pd that referenced this issue Aug 2, 2023
close tikv#6687, close tikv#6731

Fix split and split-range command bugs.

Signed-off-by: Bin Shi <binshi.bing@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant