statistics: multidimensional hot peer cache #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luffbee
added
type/enhancement
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #2140 +/- ##
==========================================
- Coverage 75.95% 75.94% -0.01%
==========================================
Files 195 195
Lines 20376 20376
==========================================
- Hits 15477 15475 -2
- Misses 3704 3709 +5
+ Partials 1195 1192 -3
Continue to review full report at Codecov.
|
rleungx
reviewed
Feb 18, 2020
nolouch
approved these changes
Feb 20, 2020
|
PTAL @rleungx |
rleungx
reviewed
Feb 21, 2020
server/statistics/topn_test.go
Outdated
| } | ||
| } | ||
|
|
||
| func putPerm(c *C, tn *TopN, K, Total int, f func(x int) float64, isUpdate bool) { |
There was a problem hiding this comment.
K, Total should start with the lowercase.
server/statistics/topn.go
Outdated
| // NOTE: panic if k <= 0 or n <= 0. | ||
| func NewTopN(k, n int, ttl time.Duration) *TopN { | ||
| if k <= 0 || n <= 0 { | ||
| panic("invalid arguments for NewTopN") |
There was a problem hiding this comment.
How about printing the value of n and k?
| _ = tn.ttlLst.Remove(id) | ||
| tn.maintain() | ||
| return item | ||
| return |
There was a problem hiding this comment.
I think return the removed item is a better API. And it is used in the test.
rleungx
approved these changes
Feb 21, 2020
Luffbee
added
the
status/can-merge
|
/run-all-tests |
nolouch
added
the
needs-cherry-pick-release-3.1
|
/run-cherry-picker |
|
cherry pick to release-3.1 in PR #2244 |
sre-bot
added a commit
that referenced
this pull request
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
First step of #2139 . The hot peer cache is not working with multidimensional load.
What is changed and how it works?
Modify the
TopNto support multidimensional load.Check List
Tests