Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: multidimensional hot peer cache (#2140) #2244

Merged
merged 9 commits into from
Mar 18, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 16, 2020

cherry-pick #2140 to release-3.1


What problem does this PR solve?

First step of #2139 . The hot peer cache is not working with multidimensional load.

What is changed and how it works?

Modify the TopN to support multidimensional load.

Check List

Tests

  • Unit test

@sre-bot sre-bot added component/schedule Scheduling logic. type/cherry-pick type/enhancement The issue or PR belongs to an enhancement. labels Mar 16, 2020
@codecov-io
Copy link

codecov-io commented Mar 16, 2020

Codecov Report

Merging #2244 into release-3.1 will increase coverage by 0.04%.
The diff coverage is 87.31%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.1    #2244      +/-   ##
===============================================
+ Coverage        74.86%   74.91%   +0.04%     
===============================================
  Files              196      196              
  Lines            20179    20222      +43     
===============================================
+ Hits             15108    15150      +42     
+ Misses            3922     3916       -6     
- Partials          1149     1156       +7     
Impacted Files Coverage Δ
server/api/trend.go 68.75% <0.00%> (ø)
server/statistics/util.go 100.00% <ø> (+3.84%) ⬆️
server/statistics/hot_peer_cache.go 85.18% <64.51%> (-3.35%) ⬇️
server/schedulers/hot_region.go 85.46% <80.00%> (ø)
server/statistics/topn.go 97.92% <94.80%> (-2.08%) ⬇️
server/statistics/hot_peer.go 100.00% <100.00%> (ø)
server/region_syncer/client.go 79.66% <0.00%> (-6.78%) ⬇️
server/heartbeat_streams.go 67.00% <0.00%> (-6.00%) ⬇️
server/tso/tso.go 77.37% <0.00%> (-2.92%) ⬇️
server/server.go 64.15% <0.00%> (-0.43%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 328984f...67618fb. Read the comment docs.

@nolouch
Copy link
Contributor

nolouch commented Mar 16, 2020

/run-all-tests

@lhy1024
Copy link
Contributor

lhy1024 commented Mar 17, 2020

Can we directly cherry-pick this pr to 3.1 without others

@nolouch nolouch added this to the v3.1.0-rc milestone Mar 17, 2020
@disksing
Copy link
Contributor

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 18, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 18, 2020

Your auto merge job has been accepted, waiting for 2252

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 18, 2020

/run-all-tests

@sre-bot sre-bot merged commit 65723c5 into tikv:release-3.1 Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/schedule Scheduling logic. status/can-merge Indicates a PR has been approved by a committer. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants