tso: make follower fail fast for tso requests #2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: disksing <i@disksing.com>
disksing
added
needs-cherry-pick-release-4.0
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
JmPotato
reviewed
Jul 8, 2020
Signed-off-by: disksing <i@disksing.com>
|
/merge |
|
Sorry @nolouch, you don't have permission to trigger auto merge event on this branch. The number of |
|
cherry pick to release-4.0 in PR #2622 |
disksing
removed
the
do-not-merge/work-in-progress
disksing
pushed a commit
that referenced
this pull request
Jul 10, 2020
|
LGTM |
|
@AndreMouche, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:scheduling(slack). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: disksing i@disksing.com
What problem does this PR solve?
It takes too long (20s) for a follower PD to return an error to client. It may cause a longer unavailable time when PD leader changes.
Note: The client will not wait for 20s, but will timeout after 3 seconds.
What is changed and how it works?
Check lease before alloc ts.
Check List
Tests
Related changes
Release note