tso: fix the bug that TSO request may fail at the time of leader changing #2665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JmPotato <ghzpotato@gmail.com>
JmPotato
added
type/bugfix
|
/run-all-tests |
|
/rebuild |
Signed-off-by: JmPotato <ghzpotato@gmail.com>
disksing
approved these changes
Jul 19, 2020
|
/run-all-tests |
lhy1024
reviewed
Jul 20, 2020
I tried to add a test case but it turned out that it's hard to simulate this situation accurately through unit test codes. |
lhy1024
approved these changes
Jul 20, 2020
ti-srebot
approved these changes
Jul 20, 2020
|
@ti-srebot /merge |
|
@JmPotato No command or invalid command |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
cherry pick to release-4.0 failed |
|
/run-cherry-picker |
|
cherry pick to release-4.0 failed |
|
/run-cherry-picker |
|
cherry pick to release-4.0 failed |
|
/run-cherry-picker |
|
cherry pick to release-4.0 failed |
|
/run-cherry-picker |
|
cherry pick to release-4.0 failed |
|
/run-cherry-picker |
ti-srebot
pushed a commit
to ti-srebot/pd
that referenced
this pull request
Jul 20, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #2666 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JmPotato ghzpotato@gmail.com
Close #2663
What problem does this PR solve?
Under the current latest version of PD, TSO request may fail at the time of leader changing because
SyncTimestampis not yet completed but PD receives a TSO request at the same time.What is changed and how it works?
Add leader lease check and try to sleep a while to wait for
SyncTimestamp.Check List
Tests
Code changes
GetRespTSmethod changeRelated changes
Release note
Fix the bug that TSO request may fail at the time of leader changing.