-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tso, server, tests: add a test case for tso allocation bug (#2675) #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot
added
component/testing
CI testing.
contribution
This PR is from a community contributor.
status/LGT2
Indicates that a PR has LGTM 2.
type/cherry-pick
labels
Jul 23, 2020
Codecov Report
@@ Coverage Diff @@
## release-4.0 #2678 +/- ##
=============================================
Coverage 77.16% 77.17%
=============================================
Files 204 205 +1
Lines 21940 22232 +292
=============================================
+ Hits 16931 17157 +226
- Misses 3724 3773 +49
- Partials 1285 1302 +17
Continue to review full report at Codecov.
|
lhy1024
approved these changes
Jul 23, 2020
ti-srebot
added
status/LGT1
Indicates that a PR has LGTM 1.
and removed
status/LGT2
Indicates that a PR has LGTM 2.
labels
Jul 23, 2020
nolouch
approved these changes
Jul 23, 2020
ti-srebot
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Jul 23, 2020
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Jul 27, 2020
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/testing
CI testing.
contribution
This PR is from a community contributor.
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #2675 to release-4.0
Signed-off-by: JmPotato ghzpotato@gmail.com
What problem does this PR solve?
Previous PR #2665 tries to fix a bug that tso allocation may fail though it's already a PD leader, which lacks of a test case can cover this situation. This pr adds a test case and makes some slight changes than before.
According to these two TiDB jenkins tests, tso may still have some problems when leader changes. I need more logs to figure out why, so this pr also adds some log info when a tso request arrive.
What is changed and how it works?
lease
as soon as possible inSyncTimestamp
.Server
for test purpose.Check List
Tests
Related changes
Release note
Add more tests and logs for TSO request.