*: refine member/tso/adapter logs #2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Leung <rleungx@gmail.com>
|
/run-all-tests |
lhy1024
reviewed
Aug 3, 2020
| @@ -0,0 +1,51 @@ | |||
| // Copyright 2020 PingCAP, Inc. | |||
There was a problem hiding this comment.
This file does not seem to include previous error types
There was a problem hiding this comment.
This file does not seem to include previous error types
Yes. I think maybe define error by the package is a better choice?
There was a problem hiding this comment.
Maybe we should deal with this error file together at last.
lhy1024
approved these changes
Aug 3, 2020
ti-srebot
approved these changes
Aug 3, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
ZenoTan
pushed a commit
to ZenoTan/pd
that referenced
this pull request
Aug 24, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com> Signed-off-by: ZenoTan <zenotan1998@gmail.com>
rleungx
added
the
needs-cherry-pick-release-4.0
|
/run-cherry-picker |
ti-srebot
pushed a commit
to ti-srebot/pd
that referenced
this pull request
Sep 4, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #2901 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Part of #2704.
What is changed and how it works?
This PR refines logs in
member/tso/adapterpackagesCheck List
Tests
Related changes
Release note