Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine the log according to RFC #2704

Closed
14 tasks done
rleungx opened this issue Aug 3, 2020 · 5 comments
Closed
14 tasks done

Refine the log according to RFC #2704

rleungx opened this issue Aug 3, 2020 · 5 comments
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@rleungx
Copy link
Member

rleungx commented Aug 3, 2020 •
edited
Loading

Development Task

According to https://github.com/pingcap/tidb/blob/master/docs/design/2020-05-08-standardize-error-codes-and-messages.md, we need to refine our error/fatal level log, but we still need to follow https://github.com/tikv/rfcs/blob/master/text/2018-12-19-unified-log-format.md.

Here are some packages we need to refine:
@rleungx rleungx added the type/enhancement The issue or PR belongs to an enhancement. label Aug 3, 2020
@lhy1024
Copy link
Contributor

lhy1024 commented Aug 3, 2020

@lhy1024 pick schedulers

@JmPotato
Copy link
Member

JmPotato commented Aug 3, 2020 •
edited
Loading

@JmPotato pick up client and placement

@howardlau1999
Copy link
Contributor

@howardlau1999 deals with cluster

@Yisaer
Copy link
Contributor

Yisaer commented Aug 3, 2020

@Yisaer pickup etcdutil and metricutil

@ZenoTan
Copy link
Contributor

ZenoTan commented Aug 3, 2020

@ZenoTan pick up server

@lhy1024 lhy1024 mentioned this issue Aug 3, 2020
Merged
@rleungx rleungx mentioned this issue Aug 3, 2020
Merged
This was referenced Aug 3, 2020
Merged
Merged
@howardlau1999 howardlau1999 mentioned this issue Aug 3, 2020
Merged
@ZenoTan ZenoTan mentioned this issue Aug 3, 2020
Closed
@JmPotato JmPotato mentioned this issue Aug 5, 2020
Merged
@rleungx rleungx mentioned this issue Aug 13, 2020
Merged
This was referenced Aug 20, 2020
Merged
Merged
@howardlau1999 howardlau1999 mentioned this issue Aug 31, 2020
Merged
@ZenoTan ZenoTan mentioned this issue Sep 1, 2020
Merged
This was referenced Sep 3, 2020
Merged
Merged
This was referenced Sep 4, 2020
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@rleungx rleungx mentioned this issue Sep 7, 2020
Merged
@ti-srebot ti-srebot mentioned this issue Sep 7, 2020
Merged
@rleungx rleungx closed this as completed Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@JmPotato @howardlau1999 @Yisaer @lhy1024 @rleungx @ZenoTan