server/cluster: refine log errs in cluster #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardlau1999
changed the title
howardlau1999
changed the title
howardlau1999
force-pushed
the
err_cluster
branch
from
426afbf
to
9354df2
Compare
ZenoTan
reviewed
Aug 3, 2020
|
/label component/log |
|
@ZenoTan PTAL |
|
@JmPotato,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: scheduling(slack). |
|
Please resolve the conflicts. |
howardlau1999
force-pushed
the
err_cluster
branch
from
36c0269
to
1f94e6c
Compare
Signed-off-by: Howard Lau <howardlau1999@hotmail.com>
howardlau1999
force-pushed
the
err_cluster
branch
from
1f94e6c
to
738edef
Compare
|
@rleungx updated. PTAL |
rleungx
reviewed
Aug 20, 2020
Signed-off-by: Howard Lau <howardlau1999@hotmail.com>
Signed-off-by: Howard Lau <howardlau1999@hotmail.com>
Signed-off-by: Howard Lau <howardlau1999@hotmail.com>
howardlau1999
force-pushed
the
err_cluster
branch
from
dbc5627
to
3597c57
Compare
|
CI failed. @howardlau1999 |
|
/merge |
|
@rleungx Oops! This PR requires at least 2 LGTMs to merge. The current number of |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
ZenoTan
pushed a commit
to ZenoTan/pd
that referenced
this pull request
Aug 24, 2020
Signed-off-by: Howard Lau <howardlau1999@hotmail.com> Signed-off-by: ZenoTan <zenotan1998@gmail.com>
jyz0309
pushed a commit
to jyz0309/pd
that referenced
this pull request
Aug 24, 2020
Signed-off-by: Howard Lau <howardlau1999@hotmail.com>
jyz0309
pushed a commit
to jyz0309/pd
that referenced
this pull request
Aug 24, 2020
Signed-off-by: Howard Lau <howardlau1999@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Howard Lau howardlau1999@hotmail.com
What problem does this PR solve?
To solve #2704
What is changed and how it works?
Check List
Tests
Release note