-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pdctl interactive mode autocomplete #2785
Conversation
Signed-off-by: jiashiwen <jiashiwen126@126.com>
Signed-off-by: jiashiwen <jiashiwen126@126.com>
/rebuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM
Signed-off-by: jiashiwen <jiashiwen126@126.com>
The PR description is not very clear, would you like to format it? |
how to do? |
Signed-off-by: jiashiwen <jiashiwen126@126.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM
Signed-off-by: jiashiwen <jiashiwen126@126.com>
idc-jenkins-ci/test error,but the unit test not my code |
/rebuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Yisaer,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: scheduling(slack). |
Signed-off-by: jiashiwen <jiashiwen126@126.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM
Signed-off-by: jiashiwen <jiashiwen126@126.com>
Signed-off-by: jiashiwen <jiashiwen126@126.com>
LGTM |
@howardlau1999,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: scheduling(slack). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
/merge |
@nolouch Oops! This PR requires at least 2 LGTMs to merge. The current number of |
* add pdctl interactive mode autocomplete Signed-off-by: jiashiwen <jiashiwen126@126.com> Signed-off-by: ZenoTan <zenotan1998@gmail.com>
* add pdctl interactive mode autocomplete Signed-off-by: jiashiwen <jiashiwen126@126.com>
* add pdctl interactive mode autocomplete Signed-off-by: jiashiwen <jiashiwen126@126.com>
What problem does this PR solve?
#2299
What is changed and how it works?
interactive mode ,use "tab" to auto complete command and flags
Check List
Tests
run pd-ctl as interactive mode
press 'tab' show command will be used
Code changes
add new varable
add new func
func getMainCmd add new expression
func loop() add
Release note