-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pd-ctl: add auto-completion for pd-ctl #2299
Conversation
* scheduelrs: add load expectations for hot scheudler Signed-off-by: nolouch <nolouch@gmail.com>
Thanks for your contribution. If your PR get merged, you will be rewarded 200 points. |
Signed-off-by: Qiannan Lyu <lvqiannan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3fc3cf2
to
492b46a
Compare
@nolouch Added zsh support, PTAL. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. BTW, is there any way to support auto-completion in interactive mode?
Signed-off-by: Qiannan Lyu <lvqiannan@gmail.com>
I have no ideas. Any recommended info about that? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
/merge |
/run-all-tests |
UCP: #2170
What problem does this PR solve?
fixed: #2170
What is changed and how it works?
Added new subcommand
completion
Check List
Tests
Help info:
Load the completion code to current shell
Type
pd-ctl cl
into the current shell, then typetab
, it will auto-complete commandpd-ctl cluster
.Code changes
tools/pd-ctl/pdctl/command/completion_command.go
tools/pd-ctl/pdctl/ctl.go
Side effects
N/A
Related changes