-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: update the error dependency and do the corresponding changes (#2760) #2902
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ryan Leung <rleungx@gmail.com>
ad09106
to
3a651b1
Compare
/merge |
/run-all-tests |
@ti-srebot merge failed. |
/run-integration-ddl-test |
1 similar comment
/run-integration-ddl-test |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #2902 +/- ##
===============================================
- Coverage 77.43% 77.40% -0.04%
===============================================
Files 209 210 +1
Lines 22777 22780 +3
===============================================
- Hits 17638 17633 -5
- Misses 3813 3819 +6
- Partials 1326 1328 +2
Continue to review full report at Codecov.
|
cherry-pick #2760 to release-4.0
What problem does this PR solve?
Related to #2704.
What is changed and how it works?
This PR updates the way to define an error and uses
Wrap
andFastGenWithCause
to output the internal error.Check List
Tests
Release note