Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update the error dependency and do the corresponding changes (#2760) #2902

Merged
merged 2 commits into from
Sep 4, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2760 to release-4.0


What problem does this PR solve?

Related to #2704.

What is changed and how it works?

This PR updates the way to define an error and uses Wrap and FastGenWithCause to output the internal error.

Check List

Tests

  • Unit test

Release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 4, 2020
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
Copy link
Member

rleungx commented Sep 4, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 4, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@nolouch
Copy link
Contributor

nolouch commented Sep 4, 2020

/run-integration-ddl-test

1 similar comment
@lhy1024
Copy link
Contributor

lhy1024 commented Sep 4, 2020

/run-integration-ddl-test

@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #2902 into release-4.0 will decrease coverage by 0.03%.
The diff coverage is 45.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #2902      +/-   ##
===============================================
- Coverage        77.43%   77.40%   -0.04%     
===============================================
  Files              209      210       +1     
  Lines            22777    22780       +3     
===============================================
- Hits             17638    17633       -5     
- Misses            3813     3819       +6     
- Partials          1326     1328       +2     
Impacted Files Coverage Δ
server/kv/etcd_kv.go 75.32% <0.00%> (-9.10%) ⬇️
server/member/leader.go 73.15% <14.28%> (-1.17%) ⬇️
client/client.go 72.43% <33.33%> (+0.48%) ⬆️
pkg/dashboard/adapter/manager.go 86.79% <50.00%> (-6.61%) ⬇️
client/base_client.go 91.27% <100.00%> (ø)
pkg/errs/errs.go 100.00% <100.00%> (ø)
pkg/etcdutil/etcdutil.go 84.05% <0.00%> (-4.35%) ⬇️
server/member/lease.go 92.18% <0.00%> (-3.13%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 930d5b6...3a651b1. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/log Log. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants