Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: optimize log and make their specification consistent (#2853) #2903

Merged
merged 1 commit into from
Sep 7, 2020
Merged

*: optimize log and make their specification consistent (#2853) #2903

merged 1 commit into from
Sep 7, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #2853 to release-4.0

What problem does this PR solve?

Related to #2704.

What is changed and how it works?

This PR does some optimization for the error log by defining the error when we first meet it.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

@ti-srebot ti-srebot mentioned this pull request Sep 4, 2020
Merged
@ti-srebot ti-srebot added component/log Log. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick labels Sep 4, 2020
@ti-srebot ti-srebot added this to the v4.0.6 milestone Sep 4, 2020
@rleungx rleungx force-pushed the release-4.0-68767909a740 branch 3 times, most recently from 49fd607 to 3c75a25 Compare September 7, 2020 03:11
JmPotato
JmPotato reviewed Sep 7, 2020
View reviewed changes
Copy link
Member

@JmPotato JmPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 7, 2020
@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 7, 2020
Yisaer
Yisaer approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Sep 7, 2020
HunDunDM
HunDunDM approved these changes Sep 7, 2020
View reviewed changes
Copy link
Member

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT4 The PR has already had 4 LGTM. and removed status/LGT3 The PR has already had 3 LGTM. labels Sep 7, 2020
@rleungx
Copy link
Member

rleungx commented Sep 7, 2020

/run-all-tests

@lhy1024
Copy link
Contributor

lhy1024 commented Sep 7, 2020

/run-all-tests

@rleungx
cherry pick tikv#2853 to release-4.0
ba4b014 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
Copy link
Member

rleungx commented Sep 7, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 7, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #2903 into release-4.0 will decrease coverage by 0.02%.
The diff coverage is 35.48%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-4.0    #2903      +/-   ##
===============================================
- Coverage        77.41%   77.38%   -0.03%     
===============================================
  Files              210      210              
  Lines            22784    22793       +9     
===============================================
+ Hits             17638    17639       +1     
- Misses            3816     3823       +7     
- Partials          1330     1331       +1
Impacted Files Coverage Δ
pkg/apiutil/serverapi/middleware.go 73.07% <0.00%> (ø)
pkg/metricutil/metricutil.go 86.11% <0.00%> (ø)
pkg/mock/mockhbstream/mockhbstream.go 89.23% <ø> (-1.54%) ⬇️
pkg/tempurl/check_env_linux.go 61.53% <0.00%> (ø)
server/api/plugin.go 9.75% <ø> (ø)
server/core/basic_cluster.go 91.37% <0.00%> (ø)
server/handler.go 51.19% <0.00%> (+0.43%) ⬆️
server/heartbeat_streams.go 68.00% <0.00%> (ø)
server/kv/etcd_kv.go 73.41% <0.00%> (-1.91%) ⬇️
server/region_syncer/history_buffer.go 83.33% <0.00%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d22b12a...ba4b014. Read the comment docs.

@ti-srebot ti-srebot merged commit d8671fe into tikv:release-4.0 Sep 7, 2020
This was referenced Sep 10, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato left review comments

@HunDunDM HunDunDM HunDunDM approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@Yisaer Yisaer Yisaer approved these changes

@nolouch nolouch Awaiting requested review from nolouch

Assignees

@rleungx rleungx

Labels
component/log Log. status/can-merge Indicates a PR has been approved by a committer. status/LGT4 The PR has already had 4 LGTM.
Projects
None yet
Milestone
v4.0.6
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @rleungx @lhy1024 @JmPotato @Yisaer @HunDunDM