Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id: fix the id allocator is not monotonic (#3305) #3306

Merged

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #3305 to release-5.0-rc


What problem does this PR solve?

What is changed and how it works?

This PR tries to make the id monotonic since there are many components that depend on this property. ref: #3303

Check List

Tests

  • Unit test

Related changes

Release note

@ti-srebot
Copy link
Contributor Author

@rleungx you're already a collaborator in bot's repo.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #3306 (c5e4260) into release-5.0-rc (9efcf3a) will decrease coverage by 0.12%.
The diff coverage is 42.85%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-5.0-rc    #3306      +/-   ##
==================================================
- Coverage           74.23%   74.11%   -0.13%     
==================================================
  Files                 243      243              
  Lines               23083    23088       +5     
==================================================
- Hits                17136    17112      -24     
- Misses               4377     4398      +21     
- Partials             1570     1578       +8     
Flag Coverage Δ
unittests 74.11% <42.85%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/server.go 72.46% <0.00%> (-0.83%) ⬇️
server/id/id.go 76.19% <54.54%> (+1.19%) ⬆️
server/tso/local_allocator.go 63.63% <0.00%> (-15.16%) ⬇️
server/schedulers/random_merge.go 56.14% <0.00%> (-3.51%) ⬇️
server/tso/allocator_manager.go 75.80% <0.00%> (-2.22%) ⬇️
server/schedule/operator/step.go 67.44% <0.00%> (-1.67%) ⬇️
pkg/btree/btree.go 85.30% <0.00%> (-0.97%) ⬇️
server/config/persist_options.go 91.43% <0.00%> (-0.78%) ⬇️
server/grpc_service.go 56.16% <0.00%> (-0.69%) ⬇️
server/cluster/coordinator.go 69.52% <0.00%> (-0.48%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9efcf3a...c5e4260. Read the comment docs.

@HunDunDM
Copy link
Member

This PR contains #3310

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@nolouch
Copy link
Contributor

nolouch commented Jan 4, 2021

/run-all-tests

@rleungx
Copy link
Member

rleungx commented Jan 5, 2021

/run-unit-test

@HunDunDM HunDunDM added this to the v5.0.0-rc milestone Jan 5, 2021
@nolouch
Copy link
Contributor

nolouch commented Jan 5, 2021

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b95c001

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 5, 2021
@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR has out-of-dated, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

@nolouch
Copy link
Contributor

nolouch commented Jan 5, 2021

/run-integration-lightning-test

@ti-chi-bot ti-chi-bot merged commit f4e7924 into tikv:release-5.0-rc Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants