-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
id: fix the id allocator is not monotonic (#3305) #3306
id: fix the id allocator is not monotonic (#3305) #3306
Conversation
@rleungx you're already a collaborator in bot's repo. |
Signed-off-by: Ryan Leung <rleungx@gmail.com>
5a5e578
to
5fa7a08
Compare
Codecov Report
@@ Coverage Diff @@
## release-5.0-rc #3306 +/- ##
==================================================
- Coverage 74.23% 74.11% -0.13%
==================================================
Files 243 243
Lines 23083 23088 +5
==================================================
- Hits 17136 17112 -24
- Misses 4377 4398 +21
- Partials 1570 1578 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This PR contains #3310 |
Signed-off-by: Ryan Leung <rleungx@gmail.com>
/run-all-tests |
/run-unit-test |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository. |
This pull request has been accepted and is ready to merge. Commit hash: b95c001
|
@ti-srebot: Your PR has out-of-dated, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository. |
/run-integration-lightning-test |
cherry-pick #3305 to release-5.0-rc
What problem does this PR solve?
What is changed and how it works?
This PR tries to make the id monotonic since there are many components that depend on this property. ref: #3303
Check List
Tests
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tidb-ansible
:Release note