id: fix the id allocator is not monotonic #3305

rleungx · 2020-12-25T09:51:45Z

What problem does this PR solve?

What is changed and how it works?

This PR tries to make the id monotonic since there are many components that depend on this property. ref: #3303

Check List

Tests

Unit test

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
PR to update pingcap/tidb-ansible:
Need to cherry-pick to the release branch

Release note

Signed-off-by: Ryan Leung <rleungx@gmail.com>

server/id/id.go

HunDunDM · 2020-12-25T10:06:28Z

server/server.go

@@ -1223,6 +1223,10 @@ func (s *Server) campaignLeader() {
 		log.Error("failed to load persistOptions from etcd", errs.ZapError(err))
 		return
 	}
+	if err := s.idAllocator.Generate(); err != nil {


I think Generate also needs mu.Lock?

codecov · 2020-12-25T10:11:34Z

Codecov Report

Merging #3305 (ffe37d6) into master (6457a48) will decrease coverage by 0.01%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##           master    #3305      +/-   ##
==========================================
- Coverage   74.71%   74.69%   -0.02%     
==========================================
  Files         243      243              
  Lines       23207    23210       +3     
==========================================
- Hits        17338    17337       -1     
+ Misses       4292     4289       -3     
- Partials     1577     1584       +7

Flag	Coverage Δ
unittests	`74.69% <70.00%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/id/id.go	`80.00% <57.14%> (+5.00%)`	⬆️
server/server.go	`72.46% <100.00%> (-1.62%)`	⬇️
pkg/tempurl/tempurl.go	`45.00% <0.00%> (-15.00%)`	⬇️
server/schedule/region_scatterer.go	`80.61% <0.00%> (-3.58%)`	⬇️
server/tso/tso.go	`78.61% <0.00%> (-2.52%)`	⬇️
server/config/persist_options.go	`91.33% <0.00%> (-0.79%)`	⬇️
server/tso/allocator_manager.go	`75.45% <0.00%> (-0.41%)`	⬇️
client/client.go	`64.93% <0.00%> (-0.38%)`	⬇️
server/cluster/cluster.go	`83.27% <0.00%> (-0.26%)`	⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6457a48...ffe37d6. Read the comment docs.

nolouch

lgtm

Rustin170506 · 2020-12-28T02:42:59Z

/lgtm

ti-chi-bot · 2020-12-28T02:43:02Z

@hi-rustin: /lgtm is only allowed for the reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

Yisaer · 2020-12-28T04:52:33Z

/merge

ti-chi-bot · 2020-12-28T04:52:34Z

@Yisaer: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

ti-chi-bot · 2020-12-28T04:52:47Z

This pull request has been accepted and is ready to merge.

Commit hash: ffe37d6

nolouch · 2020-12-28T05:11:46Z

/run-cherry-picker

ti-srebot · 2020-12-28T05:11:57Z

cherry pick to release-5.0-rc in PR #3306

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

nolouch · 2020-12-28T06:35:34Z

/run-cherry-picker

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2020-12-28T06:36:13Z

cherry pick to release-2.1 in PR #3307

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2020-12-28T06:37:09Z

cherry pick to release-4.0 in PR #3308

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2020-12-28T06:38:11Z

cherry pick to release-3.0 in PR #3309

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: Ryan Leung <rleungx@gmail.com>

* cherry pick #3305 to release-5.0-rc Signed-off-by: Ryan Leung <rleungx@gmail.com> * cherry pick #3322 to release-5.0-rc Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: ShuNing <nolouch@gmail.com> Co-authored-by: Ti Prow Robot <71242396+ti-community-prow-bot@users.noreply.github.com>

Signed-off-by: Ryan Leung <rleungx@gmail.com>

rleungx added the type/bugfix This PR fixes a bug. label Dec 25, 2020

ti-chi-bot requested a review from Yisaer December 25, 2020 09:51

fix the id allocator is not monotonic

ffe37d6

Signed-off-by: Ryan Leung <rleungx@gmail.com>

rleungx force-pushed the fix-id branch from 61dae4c to ffe37d6 Compare December 25, 2020 09:56

HunDunDM approved these changes Dec 25, 2020

View reviewed changes

server/id/id.go Show resolved Hide resolved

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 25, 2020

HunDunDM reviewed Dec 25, 2020

View reviewed changes

nolouch approved these changes Dec 25, 2020

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 25, 2020

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 28, 2020

ti-chi-bot merged commit 65e08e2 into tikv:master Dec 28, 2020

nolouch added the needs-cherry-pick-5.0-rc label Dec 28, 2020

ti-srebot mentioned this pull request Dec 28, 2020

id: fix the id allocator is not monotonic (#3305) #3306

Merged

ti-srebot pushed a commit to ti-srebot/pd that referenced this pull request Dec 28, 2020

cherry pick tikv#3305 to release-5.0-rc

5a5e578

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

nolouch added needs-cherry-pick-release-2.1 The PR needs to cherry pick to release-2.1 branch. needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. labels Dec 28, 2020

ti-srebot pushed a commit to ti-srebot/pd that referenced this pull request Dec 28, 2020

cherry pick tikv#3305 to release-2.1

84d075f

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Dec 28, 2020

id: fix the id allocator is not monotonic (#3305) #3307

Closed

ti-srebot pushed a commit to ti-srebot/pd that referenced this pull request Dec 28, 2020

cherry pick tikv#3305 to release-4.0

db215e3

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Dec 28, 2020

id: fix the id allocator is not monotonic (#3305) #3308

Merged

ti-srebot pushed a commit to ti-srebot/pd that referenced this pull request Dec 28, 2020

cherry pick tikv#3305 to release-3.0

bb5b2f9

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Dec 28, 2020

id: fix the id allocator is not monotonic (#3305) #3309

Merged

rleungx added a commit to ti-srebot/pd that referenced this pull request Dec 29, 2020

cherry pick tikv#3305 to release-3.0

82b760e

Signed-off-by: Ryan Leung <rleungx@gmail.com>

rleungx added a commit to ti-srebot/pd that referenced this pull request Dec 29, 2020

cherry pick tikv#3305 to release-4.0

bea1a62

Signed-off-by: Ryan Leung <rleungx@gmail.com>

rleungx added a commit to ti-srebot/pd that referenced this pull request Dec 29, 2020

cherry pick tikv#3305 to release-5.0-rc

5fa7a08

Signed-off-by: Ryan Leung <rleungx@gmail.com>

rleungx added a commit to ti-srebot/pd that referenced this pull request Dec 29, 2020

cherry pick tikv#3305 to release-3.0

3731b21

Signed-off-by: Ryan Leung <rleungx@gmail.com>

rleungx added a commit to ti-srebot/pd that referenced this pull request Dec 29, 2020

cherry pick tikv#3305 to release-2.1

be44bcf

Signed-off-by: Ryan Leung <rleungx@gmail.com>

rleungx added a commit to ti-srebot/pd that referenced this pull request Dec 29, 2020

cherry pick tikv#3305 to release-2.1

59d224b

Signed-off-by: Ryan Leung <rleungx@gmail.com>

rleungx added a commit to ti-srebot/pd that referenced this pull request Dec 29, 2020

cherry pick tikv#3305 to release-2.1

e11814e

Signed-off-by: Ryan Leung <rleungx@gmail.com>

rleungx added a commit to ti-srebot/pd that referenced this pull request Dec 29, 2020

cherry pick tikv#3305 to release-3.0

d176af7

Signed-off-by: Ryan Leung <rleungx@gmail.com>

ti-chi-bot pushed a commit that referenced this pull request Dec 30, 2020

cherry pick #3305 to release-4.0 (#3308)

c3874d9

Signed-off-by: Ryan Leung <rleungx@gmail.com> Co-authored-by: Ryan Leung <rleungx@gmail.com>

HunDunDM mentioned this pull request Jan 4, 2021

id: fix the bug that id may be duplicated #3322

Merged

This was referenced Jan 4, 2021

id: fix the bug that id may be duplicated (#3322) #3323

Merged

id: fix the bug that id may be duplicated (#3322) #3324

Closed

nolouch mentioned this pull request Jan 6, 2021

DDL hangs, DML reports PD server timeout and many regions miss peers pingcap/tidb#22117

Closed

rleungx added a commit to ti-srebot/pd that referenced this pull request Jan 20, 2021

cherry pick tikv#3305 to release-3.0

90be789

Signed-off-by: Ryan Leung <rleungx@gmail.com>

rleungx added a commit to ti-srebot/pd that referenced this pull request Jan 20, 2021

cherry pick tikv#3305 to release-2.1

f0a00af

Signed-off-by: Ryan Leung <rleungx@gmail.com>

rleungx added a commit to ti-srebot/pd that referenced this pull request Jan 25, 2021

cherry pick tikv#3305 to release-3.0

139478a

Signed-off-by: Ryan Leung <rleungx@gmail.com>

rleungx added a commit to ti-srebot/pd that referenced this pull request Jan 25, 2021

cherry pick tikv#3305 to release-3.0

442d15c

Signed-off-by: Ryan Leung <rleungx@gmail.com>

rleungx added a commit to ti-srebot/pd that referenced this pull request Jan 25, 2021

cherry pick tikv#3305 to release-3.0

d6aad11

Signed-off-by: Ryan Leung <rleungx@gmail.com>

rleungx added a commit to ti-srebot/pd that referenced this pull request Jan 25, 2021

cherry pick tikv#3305 to release-2.1

f78c3f9

Signed-off-by: Ryan Leung <rleungx@gmail.com>

nolouch pushed a commit that referenced this pull request Jul 1, 2021

cherry pick #3305 to release-3.0 (#3309)

4e29c2f

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

id: fix the id allocator is not monotonic #3305

id: fix the id allocator is not monotonic #3305

rleungx commented Dec 25, 2020 •

edited by nolouch

Loading

HunDunDM Dec 25, 2020

codecov bot commented Dec 25, 2020 •

edited

Loading

nolouch left a comment

Rustin170506 commented Dec 28, 2020

ti-chi-bot commented Dec 28, 2020

Yisaer commented Dec 28, 2020

ti-chi-bot commented Dec 28, 2020

ti-chi-bot commented Dec 28, 2020

nolouch commented Dec 28, 2020

ti-srebot commented Dec 28, 2020

nolouch commented Dec 28, 2020

ti-srebot commented Dec 28, 2020

ti-srebot commented Dec 28, 2020

ti-srebot commented Dec 28, 2020

id: fix the id allocator is not monotonic #3305

id: fix the id allocator is not monotonic #3305

Conversation

rleungx commented Dec 25, 2020 • edited by nolouch Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

HunDunDM Dec 25, 2020

Choose a reason for hiding this comment

codecov bot commented Dec 25, 2020 • edited Loading

Codecov Report

nolouch left a comment

Choose a reason for hiding this comment

Rustin170506 commented Dec 28, 2020

ti-chi-bot commented Dec 28, 2020

Yisaer commented Dec 28, 2020

ti-chi-bot commented Dec 28, 2020

ti-chi-bot commented Dec 28, 2020

nolouch commented Dec 28, 2020

ti-srebot commented Dec 28, 2020

nolouch commented Dec 28, 2020

ti-srebot commented Dec 28, 2020

ti-srebot commented Dec 28, 2020

ti-srebot commented Dec 28, 2020

rleungx commented Dec 25, 2020 •

edited by nolouch

Loading

codecov bot commented Dec 25, 2020 •

edited

Loading