-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
id: fix the id allocator is not monotonic (#3305) #3308
id: fix the id allocator is not monotonic (#3305) #3308
Conversation
@rleungx you're already a collaborator in bot's repo. |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #3308 +/- ##
===============================================
+ Coverage 74.77% 75.13% +0.36%
===============================================
Files 209 209
Lines 19594 19599 +5
===============================================
+ Hits 14651 14726 +75
+ Misses 3617 3540 -77
- Partials 1326 1333 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Ryan Leung <rleungx@gmail.com>
db215e3
to
bea1a62
Compare
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository. |
This pull request has been accepted and is ready to merge. Commit hash: bea1a62
|
This PR contains #3310 |
cherry-pick #3305 to release-4.0
What problem does this PR solve?
What is changed and how it works?
This PR tries to make the id monotonic since there are many components that depend on this property. ref: #3303
Check List
Tests
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tidb-ansible
:Release note