-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
movingaverage: support concurrency safe queue in AvgOverTime #3506
Conversation
Signed-off-by: yisaer <disxiaofei@163.com>
Codecov Report
@@ Coverage Diff @@
## master #3506 +/- ##
==========================================
- Coverage 74.58% 74.55% -0.03%
==========================================
Files 244 245 +1
Lines 24054 24068 +14
==========================================
+ Hits 17940 17945 +5
- Misses 4503 4509 +6
- Partials 1611 1614 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
a62649a
to
76eb425
Compare
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
@Yisaer: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 56fefee
|
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #3509 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.0 in PR #3510 |
…3509) * cherry pick #3506 to release-4.0 Signed-off-by: ti-srebot <ti-srebot@pingcap.com> * fix conflict Signed-off-by: yisaer <disxiaofei@163.com> * use init Signed-off-by: yisaer <disxiaofei@163.com> Co-authored-by: Song Gao <disxiaofei@163.com> Co-authored-by: Ti Chi Robot <71242396+ti-chi-bot@users.noreply.github.com>
Signed-off-by: yisaer disxiaofei@163.com
What is changed and how it works?
support concurrency safe queue in AvgOverTime
Check list
Benchmark Test with concurrency queue
$ go test -bench=BenchmarkCheckRegionFlow -benchtime=10s OK: 11 passed goos: darwin goarch: amd64 pkg: github.com/tikv/pd/server/statistics BenchmarkCheckRegionFlow-4 5084605 1996 ns/op PASS ok github.com/tikv/pd/server/statistics 13.584s
Benchmark Test with origin queue
$ go test -bench=BenchmarkCheckRegionFlow -benchtime=10s OK: 11 passed goos: darwin goarch: amd64 pkg: github.com/tikv/pd/server/statistics BenchmarkCheckRegionFlow-4 6700020 1814 ns/op PASS ok github.com/tikv/pd/server/statistics 15.019s
Release note