movingaverage: support concurrency safe queue in AvgOverTime (#3506) #3509
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
@Yisaer you're already a collaborator in bot's repo. |
|
/merge |
|
@Yisaer: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 73b6edd
|
ti-chi-bot
added
the
status/can-merge
Yisaer
added
the
do-not-merge/hold
|
@Yisaer please solve the conflict. |
HunDunDM
added
do-not-merge/work-in-progress
|
/lgtm cancel |
Signed-off-by: yisaer <disxiaofei@163.com>
ti-chi-bot
removed
the
status/can-merge
Codecov Report
@@ Coverage Diff @@
## release-4.0 #3509 +/- ##
===============================================
- Coverage 77.16% 75.22% -1.95%
===============================================
Files 204 210 +6
Lines 21940 19826 -2114
===============================================
- Hits 16931 14914 -2017
+ Misses 3724 3576 -148
- Partials 1285 1336 +51
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
ti-chi-bot
added
status/LGT2
|
/merge |
|
@Yisaer: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 65a7540
|
ti-chi-bot
added
the
status/can-merge
zhouqiang-cl
added
the
cherry-pick-approved
|
/merge |
|
@zhouqiang-cl: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/rebuild |
|
/run-all-test |
|
/merge |
|
@Yisaer: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/rebuild |
|
/merge |
|
@zhouqiang-cl: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
…release-4.0-610c05b7e1c4
ti-chi-bot
removed
the
status/can-merge
|
Kudos, SonarCloud Quality Gate passed!
|
|
/merge |
|
@Yisaer: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: f4ccce5
|
ti-chi-bot
added
the
status/can-merge
cherry-pick #3506 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In pd repo: git pr https://github.com/tikv/pd/pull/3509After apply modifications, you can push your change to this PR via:
Signed-off-by: yisaer disxiaofei@163.com
What is changed and how it works?
support concurrency safe queue in AvgOverTime
Check list
Benchmark Test with concurrency queue
$ go test -bench=BenchmarkCheckRegionFlow -benchtime=10s OK: 11 passed goos: darwin goarch: amd64 pkg: github.com/tikv/pd/server/statistics BenchmarkCheckRegionFlow-4 5084605 1996 ns/op PASS ok github.com/tikv/pd/server/statistics 13.584sBenchmark Test with origin queue
$ go test -bench=BenchmarkCheckRegionFlow -benchtime=10s OK: 11 passed goos: darwin goarch: amd64 pkg: github.com/tikv/pd/server/statistics BenchmarkCheckRegionFlow-4 6700020 1814 ns/op PASS ok github.com/tikv/pd/server/statistics 15.019sRelease note