Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/discovery: reduce TestRegister cost time #7946

Merged
merged 5 commits into from
Mar 27, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Mar 19, 2024

What problem does this PR solve?

Issue Number: Ref #7930

What is changed and how does it work?

can reduce from 2min to 60s
check on log

[2024/03/19 18:21:40.148 +08:00] [INFO] [register.go:73] ["exit register process"] [key=/ms/12345/test_service/registry/http://127.0.0.1:1]
[2024/03/19 18:21:40.159 +08:00] [INFO] [register.go:73] ["exit register process"] [key=/ms/12345/test_service/registry/127.0.0.1:2]
[2024/03/19 18:21:48.157 +08:00] [ERROR] [register.go:77] ["keep alive failed"] 

Check List

Tests

  • Unit test

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Mar 19, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 19, 2024
@ti-chi-bot ti-chi-bot bot requested a review from Yisaer March 19, 2024 09:21
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 19, 2024
@HuSharp HuSharp removed the request for review from Yisaer March 19, 2024 09:21
@HuSharp
Copy link
Member Author

HuSharp commented Mar 19, 2024

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2024
@HuSharp
Copy link
Member Author

HuSharp commented Mar 19, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Merging #7946 (6455e67) into master (13188c9) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7946   +/-   ##
=======================================
  Coverage   73.58%   73.59%           
=======================================
  Files         436      436           
  Lines       48464    48464           
=======================================
+ Hits        35661    35665    +4     
+ Misses       9743     9742    -1     
+ Partials     3060     3057    -3     
Flag Coverage Δ
unittests 73.59% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2024
@HuSharp HuSharp requested a review from JmPotato March 19, 2024 10:07
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 19, 2024
b, _ := os.ReadFile(fname)
l := string(b)
count := strings.Count(l, "keep alive failed")
return count >= i+1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please help explain the check here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • check log in function ServiceRegister.Register
    log.Error("keep alive failed", zap.String("key", sr.key))
  • count relates to the number of tests in the for loop to ensure that each eventually working well

Copy link
Member

@JmPotato JmPotato Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's kind of tricky to me since we may have "keep alive failed" with different meanings in logs, how can we make sure it comes from the ServiceRegister.Register definitely now and then?

Copy link
Member Author

@HuSharp HuSharp Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using regexp to make sure the log was resulted by register

and test time can be reduced to 40s
image

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp requested a review from JmPotato March 26, 2024 06:14
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 27, 2024
@JmPotato
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Mar 27, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Mar 27, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 6455e67

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 27, 2024
@ti-chi-bot ti-chi-bot bot merged commit 423e36c into tikv:master Mar 27, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants