Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort out the unit tests #7930

Open
JmPotato opened this issue Mar 18, 2024 · 0 comments
Open

Sort out the unit tests #7930

JmPotato opened this issue Mar 18, 2024 · 0 comments
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@JmPotato
Copy link
Member

JmPotato commented Mar 18, 2024 •
edited
Loading

Enhancement Task

At present, PD's unit tests are doped with some tests that will start the actual etcd/PD cluster. We should classify them as integrated tests and move them to the tests directory.

In addition, it is also necessary to provide clearer make commands to run the different tests, which helps us quickly verify any changes locally.
@JmPotato JmPotato added the type/enhancement The issue or PR belongs to an enhancement. label Mar 18, 2024
This was referenced Mar 19, 2024
Merged
Merged
ti-chi-bot bot added a commit that referenced this issue Mar 19, 2024
@HuSharp @ti-chi-bot
tests/api: replace init cluster 3 to 1 to reduce cost time (#7940)
1eeb760 
ref #7930

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot added a commit that referenced this issue Mar 19, 2024
@HuSharp @ti-chi-bot
test/pprof: replace 5s to 5 to reduce test cost time (#7939)
3fe806a 
ref #7930

reduce 30s to 5s

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@lhy1024 lhy1024 mentioned this issue Mar 19, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this issue Mar 19, 2024
@lhy1024
tests: reduce etcdutil test time (#7945)
b0c49fa 
ref #7930

Signed-off-by: lhy1024 <admin@liudos.us>
@HuSharp HuSharp mentioned this issue Mar 19, 2024
Merged
@lhy1024 lhy1024 mentioned this issue Mar 19, 2024
Merged
This was referenced Mar 20, 2024
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Mar 20, 2024
@HuSharp
tests/label: use eventually to make sure label equal (#7949)
b5c56b6 
ref #7930

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@lhy1024 lhy1024 mentioned this issue Mar 20, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this issue Mar 21, 2024
@lhy1024 @disksing
tests/api: reduce TestRegionsWithKillRequest test time (#7953)
bb8ba31 
ref #7930

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: disksing <i@disksing.com>
ti-chi-bot bot added a commit that referenced this issue Mar 21, 2024
@HuSharp @ti-chi-bot
tests/server: move TestCheckClusterID out of leaderServerTestSuite (
89a8087 
#7950)

ref #7930

which can use parallel test

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@HuSharp HuSharp mentioned this issue Mar 22, 2024
Closed
ti-chi-bot bot added a commit that referenced this issue Mar 25, 2024
@lhy1024 @ti-chi-bot
tests/etcdutil: reduce TestRandomKillEtcd test time (#7947)
39108f7 
ref #7930

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot pushed a commit that referenced this issue Mar 27, 2024
@HuSharp
tests/discovery: reduce TestRegister cost time (#7946)
423e36c 
ref #7930

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@okJiang okJiang mentioned this issue Oct 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JmPotato