Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/label: use eventually to make sure label equal #7949

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Mar 20, 2024

What problem does this PR solve?

Issue Number: Ref #7930

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: husharp <jinhao.hu@pingcap.com>
Copy link
Contributor

ti-chi-bot bot commented Mar 20, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Merging #7949 (c30b646) into master (b0c49fa) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7949      +/-   ##
==========================================
- Coverage   73.49%   73.45%   -0.04%     
==========================================
  Files         436      436              
  Lines       48363    48363              
==========================================
- Hits        35545    35526      -19     
- Misses       9760     9776      +16     
- Partials     3058     3061       +3     
Flag Coverage Δ
unittests 73.45% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 20, 2024
@HuSharp HuSharp added the require-LGT1 Indicates that the PR requires an LGTM. label Mar 20, 2024
@HuSharp
Copy link
Member Author

HuSharp commented Mar 20, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Mar 20, 2024

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Mar 20, 2024

This pull request has been accepted and is ready to merge.

Commit hash: c30b646

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 20, 2024
@ti-chi-bot ti-chi-bot bot merged commit b5c56b6 into tikv:master Mar 20, 2024
26 of 27 checks passed
@HuSharp HuSharp deleted the fix_label_ttl branch March 20, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants