Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashboard): update TiDB Dashboard to 6.5.9-0f035e0e [release-6.5] #7987

Merged
merged 5 commits into from
Mar 28, 2024

Conversation

baurine
Copy link
Contributor

@baurine baurine commented Mar 27, 2024

What problem does this PR solve?

Issue Number: Close #7994 ref #4257 #7561

Update TiDB Dashboard to v6.5.9-0f035e0e.

This PR will support ticdc and tiproxy for 6.5 version as well.

Release note

None

Test

$ make pd-server
$ cp bin/pd-server ~/.tiup/components/pd/v6.5.8/pd-server   
$ tiup playground 6.5.8 --tiflash 0

image

image

image

baurine and others added 5 commits March 27, 2024 13:54
close tikv#7612

Signed-off-by: baurine <2008.hbl@gmail.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: baurine <2008.hbl@gmail.com>
Signed-off-by: baurine <2008.hbl@gmail.com>
…v#7563)

close tikv#7561

Pass TLS info to dashboard to fix TiKV heap profiling

Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Signed-off-by: baurine <2008.hbl@gmail.com>
Copy link
Contributor

ti-chi-bot bot commented Mar 27, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Mar 27, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 27, 2024

Hi @baurine. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from disksing and JmPotato March 27, 2024 06:25
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 75.45%. Comparing base (cb07342) to head (3250838).

Files Patch % Lines
pkg/grpcutil/grpcutil.go 78.57% 2 Missing and 1 partial ⚠️
pkg/dashboard/adapter/config.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-6.5    #7987      +/-   ##
===============================================
- Coverage        75.46%   75.45%   -0.02%     
===============================================
  Files              332      332              
  Lines            33790    33798       +8     
===============================================
+ Hits             25501    25503       +2     
- Misses            6080     6089       +9     
+ Partials          2209     2206       -3     
Flag Coverage Δ
unittests 75.45% <68.75%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

ti-chi-bot bot commented Mar 28, 2024

@mornyx: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@HuSharp
Copy link
Member

HuSharp commented Mar 28, 2024

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Mar 28, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 28, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 28, 2024
@HuSharp HuSharp requested review from lhy1024 and rleungx and removed request for disksing March 28, 2024 05:27
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 28, 2024
@JmPotato
Copy link
Member

/merge

Copy link
Contributor

ti-chi-bot bot commented Mar 28, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Mar 28, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 3250838

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 28, 2024
@ti-chi-bot ti-chi-bot bot merged commit 256d793 into tikv:release-6.5 Mar 28, 2024
19 of 20 checks passed
@baurine baurine deleted the update-tidb-dashboard-6.5 branch March 28, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants