More kinds for maki icon library support #1541

zerebubuth · 2018-06-20T16:42:05Z

Added some more kinds related to #1423.

gaming
garden_centre
golf
grocery
harbor
naval_base
port_terminal
ferry_terminal landuse
container_terminal
shipyard
wharf
quay
boatyard
boat_lift
ship_chandler
customs

(NOTE: we already had man_made=crane mapped to kind: crane, so there wasn't a need to add that.)

Some follow-ups:

Added a kind for grocery. We already had greengrocer and, looking at the Wikipedia pages for grocery compared with greengrocer, I'm not sure that they're the same thing. For the moment, I've left them as separate kinds.
Many items tagged as harbour=yes are also tagged as other things. For example, this port terminal is tagged harbour=yes, landuse=port_terminal, man_made=pier; should that be output as a harbour, port terminal or pier - or should we split the geometry to allow multiple features for the harbour landuse and pier, with a POI for the port terminal? Also, this pier is tagged harbour=yes, man_made=pier - should that be harbour, pier or split into two features?
The customs kind mentions the amenity=customs tag, which has only 742 uses. Should we also include the barrier=border_control tag, which has over 5,000 uses? Should they both be mapped to kind customs, or are customs (i.e: taxation) and border control sufficiently distinct things to deserve distinct kinds?

…es of greengrocer, which was already included.

… to cherry pick specific instances for exploring corner cases.

nvkelso · 2018-06-20T16:56:03Z

Added a kind for grocery. We already had greengrocer and, looking at the Wikipedia pages for grocery compared with greengrocer, I'm not sure that they're the same thing. For the moment, I've left them as separate kinds.

In SF they are different things, I think we should set as different kind values. Not saying they're always tagged right, but they are different.

Many items tagged as harbour=yes are also tagged as other things. For example, this port terminal is tagged harbour=yes, landuse=port_terminal, man_made=pier; should that be output as a harbour, port terminal or pier - or should we split the geometry to allow multiple features for the harbour landuse and pier, with a POI for the port terminal? Also, this pier is tagged harbour=yes, man_made=pier - should that be harbour, pier or split into two features?

Seems like harbour=yes is being used as a generic grouper here that we should ignore and we should only use and export landuse%3Dharbour.

For 256125920 I'd expect port_terminal. Not excited about splitting for multiple features unless there's a compelling case for it.

For 183049783 I'd expect pier.

The customs kind mentions the amenity=customs tag, which has only 742 uses. Should we also include the barrier=border_control tag, which has over 5,000 uses? Should they both be mapped to kind customs, or are customs (i.e: taxation) and border control sufficiently distinct things to deserve distinct kinds?

Both as distinct kinds, please.

BTW, barrier=border_control is requested in #1424 which is in this milestone, can include in this PR or in later PRs.

nvkelso · 2018-06-20T16:57:04Z

yaml/landuse.yaml

+    min_zoom: 16
+    output:
+      <<: *output_properties
+      kind: harbor


Our practice on the kinds is generally to follow British English, especially if that's what the original OSM tag was.

Please set this to harbour.

See PR comments – this should move to landuse: harbour only, and can be merged with the next filter.

harbor -> harbour in 96110df.

nvkelso · 2018-06-20T16:57:51Z

yaml/pois.yaml

@@ -1614,6 +1614,13 @@ filters:
    output:
      <<: *output_properties
      kind: petroleum_well
+  # a boat lift is a more specific type of object than a crane, although it may


👍 Useful note explaining the order of filters.

nvkelso · 2018-06-20T16:58:17Z

yaml/pois.yaml

+    min_zoom: 17
+    output:
+      <<: *output_properties
+      kind: gaming


I think the kind should be adult_gaming_centre

Changed in 96110df.

nvkelso · 2018-06-20T16:59:55Z

yaml/landuse.yaml

+    output:
+      <<: *output_properties
+      kind: naval_base
+      kind_detail: military


Why is the kind_detail set here? Are there naval bases that aren't military related?

Ah, sorry, I think that was copy-pasta from the above airfield, where it makes sense to say it's a military thing. Civilian airfields exist, but civilian naval bases, as you rightly point out, not so much. Fixed in 96110df.

nvkelso · 2018-06-20T17:01:26Z

integration-test/1423-kinds-for-maki-icon-library-support.py

+        self.assert_has_feature(
+            z, x, y, 'landuse', {
+                'id': 183049783,
+                # should be 'kind': u'harbor',?


Resolve this before merging.

Resolved in 96110df.

…r=yes, *_terminal > pier.

nvkelso · 2018-06-20T21:51:14Z

docs/layers.md

@@ -524,6 +526,7 @@ _TIP: Some `landuse` features only exist as point features in OpenStreetMap. Fin
 * `groyne`
 * `guard_rail`
 * `hanami`
+* `harbor` (a.k.a harbour)


Also fix the documentation spelling (to harbour without the parenthetical note)

Ooops, well spotted. Thanks. Fixed in 745f2e5.

nvkelso · 2018-06-20T21:51:44Z

docs/layers.md

@@ -879,16 +890,20 @@ To resolve inconsistency in data tagging in OpenStreetMap we normalize several o
 * `fuel` - Fuel stations provide liquid gas (or diesel) for automotive use.
 * `furniture`
 * `gallery` - An art gallery.
+* `gaming`


This name also changes to adult_gaming_centre?

Thanks for pointing that out. Fixed in 745f2e5.

nvkelso · 2018-06-20T21:52:40Z

docs/layers.md

 * `golf_course`
 * `government`
-* `greengrocer`
+* `greengrocer` - Shop selling fruits and vegetables.
+* `grocery` - Shop selling non-perishable foods.


Shop selling non-perishable foods, also known as a "supermarket".?

I changed it to:

Shop selling non-perishable food often similar to, but smaller than, a supermarket. See also grocery store on Wikipedia.

I get the impression from that Wikipedia article that a grocery store doesn't generally sell fresh fruits and vegetables, nor non-food items. I can't remember ever having been in a store which had such a laser focus - all the ones which come to mind either additionally sold stationery, cards, household products and similar non-food items (and might be called a newsagents or convenience store), or had a fridge/freezer section for selling perishable food.

Should we merge this into supermarket or convenience?

In the USA grocery is probably more akin to "corner store" or "bodega" versus a supermarket which is a usually "big box" style store. Fine as-is from OSM.

nvkelso

LGTM asside from couple minor documentation change requests.

nvkelso · 2018-06-20T21:57:17Z

yaml/landuse.yaml

@@ -1116,3 +1132,14 @@ filters:
      <<: *output_properties
      kind: crane
      kind_detail: {col: "crane:type"}
+  - filter:
+      landuse:
+        - harbour


I think harbour should go into the general port group above, with the min zoom clamp of 11 to 16 ... Possibly also port.

OK. Moved harbour and port in 745f2e5.

nvkelso · 2018-06-20T21:58:23Z

yaml/landuse.yaml

+        - shipyard
+        - wharf
+        - quay
+    min_zoom: 16


15 for port and shipyard, 16 for wharf and quay?

Updated, and added tests in 745f2e5.

…nd gaming->adult_gaming_centre. Altered min_zooms for port or harbour-related landuse.

zerebubuth added 6 commits June 20, 2018 11:16

Add adult gaming centres.

4f2376c

Add garden centres.

40199e3

Added golf stores.

185662f

Add groceries - seems a very specialised tag in OSM. Far more instanc…

26416da

…es of greengrocer, which was already included.

Add support for fetching from Overpass by element ID. Makes it easier…

546d1e2

… to cherry pick specific instances for exploring corner cases.

Add many harbour-related landuse and POI features.

18c9c1d

zerebubuth requested a review from nvkelso June 20, 2018 16:42

nvkelso reviewed Jun 20, 2018

View reviewed changes

Fixes; harbor->harbour, gaming->adult_gaming_centre, don't use harbou…

96110df

…r=yes, *_terminal > pier.

nvkelso reviewed Jun 20, 2018

View reviewed changes

nvkelso approved these changes Jun 20, 2018

View reviewed changes

nvkelso reviewed Jun 20, 2018

View reviewed changes

Updated documentation to match previous changes for harbor->harbour a…

745f2e5

…nd gaming->adult_gaming_centre. Altered min_zooms for port or harbour-related landuse.

zerebubuth merged commit 19f65a8 into master Jun 21, 2018

zerebubuth deleted the zerebubuth/1423-kinds-for-maki-icon-library-support branch June 21, 2018 11:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More kinds for maki icon library support #1541

More kinds for maki icon library support #1541

zerebubuth commented Jun 20, 2018

nvkelso commented Jun 20, 2018

nvkelso Jun 20, 2018

nvkelso Jun 20, 2018 •

edited

Loading

zerebubuth Jun 20, 2018

nvkelso Jun 20, 2018

nvkelso Jun 20, 2018

zerebubuth Jun 20, 2018

nvkelso Jun 20, 2018

zerebubuth Jun 20, 2018

nvkelso Jun 20, 2018

zerebubuth Jun 20, 2018

nvkelso Jun 20, 2018

zerebubuth Jun 21, 2018

nvkelso Jun 20, 2018 •

edited

Loading

zerebubuth Jun 21, 2018

nvkelso Jun 20, 2018

zerebubuth Jun 21, 2018

nvkelso Jun 21, 2018

nvkelso left a comment

nvkelso Jun 20, 2018

zerebubuth Jun 21, 2018

nvkelso Jun 20, 2018

zerebubuth Jun 21, 2018

More kinds for maki icon library support #1541

More kinds for maki icon library support #1541

Conversation

zerebubuth commented Jun 20, 2018

nvkelso commented Jun 20, 2018

Choose a reason for hiding this comment

nvkelso Jun 20, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nvkelso Jun 20, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nvkelso left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nvkelso Jun 20, 2018 •

edited

Loading

nvkelso Jun 20, 2018 •

edited

Loading