Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More kinds for maki icon library support #1541

Merged
merged 8 commits into from
Jun 21, 2018
Merged

More kinds for maki icon library support #1541

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4f2376c
Add adult gaming centres.
zerebubuth Jun 20, 2018
40199e3
Add garden centres.
zerebubuth Jun 20, 2018
185662f
Added golf stores.
zerebubuth Jun 20, 2018
26416da
Add groceries - seems a very specialised tag in OSM. Far more instanc…
zerebubuth Jun 20, 2018
546d1e2
Add support for fetching from Overpass by element ID. Makes it easier…
zerebubuth Jun 20, 2018
18c9c1d
Add many harbour-related landuse and POI features.
zerebubuth Jun 20, 2018
96110df
Fixes; harbor->harbour, gaming->adult_gaming_centre, don't use harbou…
zerebubuth Jun 20, 2018
745f2e5
Updated documentation to match previous changes for harbor->harbour a…
zerebubuth Jun 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion docs/layers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,7 @@ _TIP: Some `landuse` features only exist as point features in OpenStreetMap. Fin
* `college`
* `commercial`
* `common`
* `container_terminal`
* `crane`
* `cutline`
* `danger` - e.g: military training zones, firing ranges.
Expand All @@ -510,6 +511,7 @@ _TIP: Some `landuse` features only exist as point features in OpenStreetMap. Fin
* `farmland`
* `farmyard`
* `fence` - if present, `kind_detail` one of `avalanche`, `barbed_wire`, `bars`, `brick`, `chain`, `chain_link`, `concrete`, `drystone_wall`, `electric`, `grate`, `hedge`, `metal`, `metal_bars`, `net`, `pole`, `railing`, `railings`, `split_rail`, `steel`, `stone`, `wall`, `wire`, `wood`.
* `ferry_terminal`
* `footway`
* `forest`
* `fort`
Expand All @@ -524,6 +526,7 @@ _TIP: Some `landuse` features only exist as point features in OpenStreetMap. Fin
* `groyne`
* `guard_rail`
* `hanami`
* `harbor` (a.k.a harbour)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fix the documentation spelling (to harbour without the parenthetical note)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, well spotted. Thanks. Fixed in 745f2e5.

* `hospital`
* `industrial`
* `kerb`
Expand All @@ -537,6 +540,7 @@ _TIP: Some `landuse` features only exist as point features in OpenStreetMap. Fin
* `natural_forest` - _See planned bug fix in [#1096](https://github.com/tilezen/vector-datasource/issues/1096)._
* `natural_park` - _See planned bug fix in [#1096](https://github.com/tilezen/vector-datasource/issues/1096)._
* `natural_wood` - _See planned bug fix in [#1096](https://github.com/tilezen/vector-datasource/issues/1096)._
* `naval_base`
* `park`
* `parking`
* `pedestrian`
Expand All @@ -547,11 +551,13 @@ _TIP: Some `landuse` features only exist as point features in OpenStreetMap. Fin
* `place_of_worship`
* `plant`
* `playground`
* `port_terminal`
* `power_line`
* `power_minor_line`
* `prison`
* `protected_area`
* `quarry`
* `quay`
* `railway`
* `recreation_ground`
* `recreation_track`
Expand All @@ -568,6 +574,7 @@ _TIP: Some `landuse` features only exist as point features in OpenStreetMap. Fin
* `scree`
* `scrub`
* `service_area`
* `shipyard`
* `snow_fence`
* `sports_centre`
* `stadium`
Expand All @@ -589,6 +596,7 @@ _TIP: Some `landuse` features only exist as point features in OpenStreetMap. Fin
* `water_slide`
* `water_works`
* `wetland`
* `wharf`
* `wilderness_hut`
* `wildlife_park`
* `winery`
Expand Down Expand Up @@ -794,6 +802,8 @@ To resolve inconsistency in data tagging in OpenStreetMap we normalize several o
* `boat_rental`
* `boat_storage`
* `bollard`
* `boatyard`
* `boat_lift`
* `books`
* `brewery`
* `bus_station`
Expand Down Expand Up @@ -833,6 +843,7 @@ To resolve inconsistency in data tagging in OpenStreetMap we normalize several o
* `courthouse`
* `crane`
* `cross`
* `customs` - A place where border control is carried out, which may involve [customs taxes](https://en.wikipedia.org/wiki/Customs_(tax)).
* `cycle_barrier` - Barrier for bicycles.
* `dairy_kitchen`
* `danger` - e.g: military training zones, firing ranges.
Expand Down Expand Up @@ -879,16 +890,20 @@ To resolve inconsistency in data tagging in OpenStreetMap we normalize several o
* `fuel` - Fuel stations provide liquid gas (or diesel) for automotive use.
* `furniture`
* `gallery` - An art gallery.
* `gaming`
Copy link
Member

@nvkelso nvkelso Jun 20, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name also changes to adult_gaming_centre?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out. Fixed in 745f2e5.

* `garden` - _See planned bug fixes in [#1085](https://github.com/tilezen/vector-datasource/issues/1085)._
* `gardener`
* `garden_centre`
* `gas_canister` - Shop selling bottled gas for cooking. Some offer gas canister refills.
* `gate` - with `kind_detail` one of `chain`, `gate`, `kissing_gate`, `lift_gate`, `stile`, `swing_gate`.
* `generator`
* `geyser`
* `gift`
* `golf` - Shop selling golf equipment.
* `golf_course`
* `government`
* `greengrocer`
* `greengrocer` - Shop selling fruits and vegetables.
* `grocery` - Shop selling non-perishable foods.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shop selling non-perishable foods, also known as a "supermarket".?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to:

Shop selling non-perishable food often similar to, but smaller than, a supermarket. See also grocery store on Wikipedia.

I get the impression from that Wikipedia article that a grocery store doesn't generally sell fresh fruits and vegetables, nor non-food items. I can't remember ever having been in a store which had such a laser focus - all the ones which come to mind either additionally sold stationery, cards, household products and similar non-food items (and might be called a newsagents or convenience store), or had a fridge/freezer section for selling perishable food.

Should we merge this into supermarket or convenience?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the USA grocery is probably more akin to "corner store" or "bodega" versus a supermarket which is a usually "big box" style store. Fine as-is from OSM.

* `group_home`
* `guest_house`
* `hairdresser`
Expand Down Expand Up @@ -1011,6 +1026,7 @@ To resolve inconsistency in data tagging in OpenStreetMap we normalize several o
* `scuba_diving`
* `service_area`
* `shelter`
* `ship_chandler`
* `shoemaker`
* `shoes`
* `shower`
Expand Down
Loading