-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lua changes for targeted disputed borders fixes #2065
Conversation
…ub.com/tilezen/vector-datasource into travisg/20220204-disputed_by-unpacking
…sputed_by-unpacking
…isputed relations. This should hopefully convert affected borders to kind=disputed_reference_line.
…acking' into travisg/20220204-disputed_by-unpacking
…for retagging boundaries
…ub.com/tilezen/vector-datasource into travisg/20220204-disputed_by-unpacking
@@ -643,7 +813,11 @@ function osm2pgsql.process_relation(object) | |||
-- Adds tags to redefine Israel admin 4 boundaries for Palestine. | |||
if type == 'boundary' and (object.tags.admin_level == '4') and object.tags['ISO3166-2'] then | |||
if osm2pgsql.has_prefix(object.tags['ISO3166-2'], 'IL-') then | |||
output_hstore['admin_level:PS'] = '6' | |||
output_hstore['admin_level:BD'] = '8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will require a style sheet change, which is ok.
But I think a better result would be kind:xx
= unrecognized
in the output tiles because we want a way to turn them off while still showing locality lines elsewhere. Is there a different way you can tag these here to achieve that result?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can stay.
osm2pgsql.lua
Outdated
@@ -658,6 +832,42 @@ function osm2pgsql.process_relation(object) | |||
output_hstore['admin_level'] = '4' | |||
end | |||
|
|||
-- Turn off West Bank and Judea and Samaria relations for everyone but Israel | |||
if type == 'boundary' and object.tags.wikidata == 'Q36678' then | |||
output_hstore['admin_level:AR'] = '8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will require a style sheet change, which is ok.
But I think a better result would be kind:xx
= unrecognized
in the output tiles because we want a way to turn them off while still showing locality lines elsewhere. Is there a different way you can tag these here to achieve that result?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please turn this one off entirely, for all viewpoints. This means Israel won't see it, for now. But we'll followup with more complex solution.
if object.tags.place and object.tags.wikidata == 'Q1246' then | ||
output_hstore['disputed_by'] = 'CN;GR;IN;RU' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all other countries we consider we'd end up with kind:XX
= country
for the other Natural Earth POVs.
Lua updates to support disputed borders