Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lua changes for targeted disputed borders fixes #2065
Lua changes for targeted disputed borders fixes #2065
Changes from 76 commits
bfec354
a3e673c
1b82db4
665867b
01e2755
d9d52f1
fb12139
2b432e8
dd7f18c
d9d49ec
7c634a8
ab85e9b
0d8c2af
3d730aa
f23ea41
3797723
45228fb
edd2304
5ca4752
4842284
8f4a26d
275022e
33c5658
68715e3
98d4b5f
d7af921
aa68e5e
8aa30c0
153f4cd
ebd6d60
3a04505
d7623be
3581e05
c8fe78c
9c6e07f
e2e418f
2e427aa
b83aa5b
6b496b5
b5eafe9
7232975
f8cbceb
e6c29f6
cd98dba
c6f363a
063e5b5
4ca3e01
18c9181
b2871ea
1e3e080
2948ba9
747bcd1
7f0decf
6e450d6
0ae7da5
04c1413
3e37ac2
577348a
9e83abd
8898f2e
b27d1b0
e025c8c
d1d1c59
79aec39
bf62b6e
7519605
594dabb
7114868
802ae74
57cfd00
ebace4b
b241e4d
2c261d0
2562c87
8a1115f
e11c2d5
6e39e2b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all other countries we consider we'd end up with
kind:XX
=country
for the other Natural Earth POVs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will require a style sheet change, which is ok.
But I think a better result would be
kind:xx
=unrecognized
in the output tiles because we want a way to turn them off while still showing locality lines elsewhere. Is there a different way you can tag these here to achieve that result?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can stay.