Add suggestions/fixes to skeleton #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmyichen
reviewed
Oct 18, 2019
Lobarr
changed the title
timmyichen
approved these changes
Oct 19, 2019
timmyichen
added a commit
that referenced
this pull request
Oct 21, 2019
* basic app skeleton * update readme * remove body parser * tsconfig target esnext * nodemon -> dev dep * api route examples * custom typing for responseErrorHandler * oops fix speccy location * tslint -> eslint * add dockerfile, update installation instructions in README * emptyline at end of eslintignore * Revert "add dockerfile, update installation instructions in README" This reverts commit 8075dc4. * Revert "Revert "add dockerfile, update installation instructions in README"" This reverts commit cf502e5. * fix dockerfile and use npm ci * update readme, update nodemon watch files * add next to the docs * Add suggestions/fixes to skeleton (#1) * chore: added speccy to docker compose dev environment * chore: added speccy to dev deps, added/updated scripts, fixed husky warning * test: added test for SomeComponent * docs: updated scripts and added testing * chore: setup jest testing * no more dockerfile, update docs * add js and jsx extensions to configs * chore: removed unnecessary network, switched to using top level volume (#2) * Mvp/skeleton (#3) * fix(setup) Add note for linux users about docker-compose problem with PWD * fix(client) Use named functions for components * fix(setup) Turn of ts noImplicitAny * fix(setup) Use es6 imports in next config * fix(docker) Remove top level volumes * fix(setup) add newline to end of package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update README.md).masterbranch of Chapter.Closes #XXXXX
Description of Changes