-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need warn about ts files (not dts) in compilation from node_modules #53
Comments
Hi, the error happens for But anyway it is bug and I'll fix it. |
@rhuitl There is some other thoughts about it: the library To remove js-output-specific stuff (like function's body, full class' implementation and so on) As workaround (and, actually, right solution) I believe that |
So, according my previous comment I don't think that it is actually bug. We can try to warn about such situations, but I'm not sure whether we should fix it in this tool. |
Yes you are right, with the correct file in the typings field, dts-bundle-generator works just fine. We could as well close this ticket now :) Thanks for your support. |
The |
It does? Wow, I didn't know that! If it's really does it, I believe this bug can be fixed. But just for an information - what's a case you publish non-transpiled sources? Who'll execute/compile it when somebody install it? I'm not sure if it's correct to do this. |
Oh, I see. Just add |
Why do you decide that TypeScript compiler compiles node_modules folder? I see that after building |
If you ask me, inlining should be opt-in. But yes, that is a good workaround. 👍 |
What do you mean? |
By default, when
Yeah, I didn't mean to imply that. Notice how |
I can't imagine a case where it's ok, even for monorepos, because it would be better to have compiled Also, I believe that in case of monorepo you need to compile dependencies first and generate Also that warning is about
Not actually. Resolving symlinks are for the TypeScript compiler. After the compiler creates the program,
How to detect that some module is external one? It looks like we have a path of the file only for that. |
In my scenario, each package contains both If they instead used each other's
In my scenario, the uncompiled
Hmm, you could probably gather the |
I'm back after looong time :)
Hm, it's a little bit unexpected for me. I believe it speeds up builds, but it confuses.
Yeah, I need. There is a lot of issues caused by that - https://github.com/timocov/dts-bundle-generator/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+label%3Adetect-import-path-problem
I believe in this case you need to have resolver/scheduler which will make a build plan and detect which packages can be built in parallel. I just dig into
and it seems that there is no way to get dts file for module from If you ignore that warning, does it work correct for you or you get some errors? /cc @aleclarson |
Hey @timocov, shortly after trying your tool, I decided to start contributing to Since I don't need your library now, I won't be able to justify helping you out. Sorry! |
Ok, no problem! |
I would like to include the typings for https://github.com/Lusito/typed-signals in my DTS bundle, however the extraction fails with "Error: Cannot find symbol for node: emitCollecting".
app.ts:
package.json:
tsconfig.json:
Run:
Output:
The method looks like this (see https://github.com/Lusito/typed-signals/blob/master/src/Signal.ts):
The text was updated successfully, but these errors were encountered: