This repository has been archived by the owner on Jun 15, 2023. It is now read-only.
Add a CI step to decode the EDID #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's difficult to inspect source changes to the EDID, as we store it as a hex blob. This change improves inspection slightly by decoding the EDID and printing it to CI logs.
Automated comment from CodeApprove ➜⏳ @cghague please review this Pull Request |
cghague
suggested changes
Apr 26, 2023
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
⏳ Approval Pending (1 unresolved comments)
Approval will be granted automatically when all comments are resolved
LGTM.
In: .circleci/config.yml:
> Line 35
command: sudo apt-get update && sudo apt-get install edid-decode
We include the -y option in some of our other CircleCI steps. I don't believe it's strictly necessary in this case, but it might be worth adding it for consistency.
👀 @mtlynch it's your turn please take a look
cghague
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
Approved: I have approved this change on CodeApprove and all of my comments have been resolved.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves tiny-pilot/tinypilot#1373
It's difficult to inspect source changes to the EDID, as we store it as a hex blob. This change improves inspection slightly by decoding the EDID and printing it to CI logs.
