Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run edid-decode as part of CI #1373

Closed
mtlynch opened this issue Apr 25, 2023 · 0 comments · Fixed by tiny-pilot/ansible-role-ustreamer#102
Closed

Run edid-decode as part of CI #1373

mtlynch opened this issue Apr 25, 2023 · 0 comments · Fixed by tiny-pilot/ansible-role-ustreamer#102
Labels
enhancement New feature or request

Comments

@mtlynch
Copy link
Contributor

mtlynch commented Apr 25, 2023

As we're making changes to the TinyPilot EDID as part of the MacOS 13.3 issue, I'm realizing that it's pretty labor-intensive to inspect TinyPilot's EDID. We store it as a hex-encoded binary blob, but that means that changes to it are opaque until we import

We should add a step in CircleCI where we print out the decoded value of the EDID using edid-decode. To do this, we might have to store the EDID as its own file rather than as hex within the YAML. But we should have something in the CI logs that runs the EDID through edid-decode and prints it in the CI logs. That way, when we make EDID changes, it's easy to diff what's changed by comparing the current CI run to the CI logs in the main branch.
@mtlynch mtlynch added the enhancement New feature or request label Apr 25, 2023
@mtlynch mtlynch mentioned this issue Apr 26, 2023
Merged
mtlynch added a commit to tiny-pilot/ansible-role-ustreamer that referenced this issue Apr 26, 2023
@mtlynch
Add a CI step to decode the EDID (#102)
99babd8 
Resolves tiny-pilot/tinypilot#1373

It's difficult to inspect source changes to the EDID, as we store it as
a hex blob. This change improves inspection slightly by decoding the
EDID and printing it to CI logs.
<a data-ca-tag
href="https://codeapprove.com/pr/tiny-pilot/ansible-role-ustreamer/102"><img
src="https://codeapprove.com/external/github-tag-allbg.png" alt="Review
on CodeApprove" /></a>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a CI step to decode the EDID tiny-pilot/ansible-role-ustreamer
1 participant
@mtlynch