Drop support for uStreamer 4.x and Debian 10 #105
Conversation
|
@mtlynch do we need to adjust our Github settings? As of this PR, we’d only have one unified
|
Yep, I've just updated to get rid of the old jobs. |
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
✔️ Approved
Yay, less code. LGTM!
👀 @jotaen4tinypilot it's your turn please take a look
|
@mtlynch shall we cut a new release and bump Pro’s Ansible requirement? Not sure what our policy is here, since this is a non-functional change for Pro. |
|
Sure! Just created a PR: https://github.com/tiny-pilot/tinypilot-pro/pull/891 |
Resolves #99 (which was re-opened). In [a previous PR, in which we abandoned Buster-specific compatibility code](#105), we forgot to remove a workaround that was needed for the systemd version that Buster shipped with. In versions up until v244, systemd [didn’t support the `on-failure` restart method for “oneshot” type units](systemd/systemd#13754). Therefore, we had to use a “simple” type unit, because [Debian 10 (Buster) shipped with systemd v241](https://packages.debian.org/buster/systemd). However, [Debian 11 (Bullseye) ships with systemd v247](https://packages.debian.org/bullseye/systemd), so we can abandon this workaround now. <a data-ca-tag href="https://codeapprove.com/pr/tiny-pilot/ansible-role-ustreamer/107"><img src="https://codeapprove.com/external/github-tag-allbg.png" alt="Review on CodeApprove" /></a>
Resolves #99.
This PR drops support for uStreamer 4.x and Debian 10. This implies abandoning support for the OMX encoder, which was uStreamer-4-only.
