This repository has been archived by the owner on Jun 15, 2023. It is now read-only.
Remove workaround for legacy systemd versions #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdeanwallace
approved these changes
May 9, 2023
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
✔️ Approved
LGTM!
In: templates/load-tc358743-edid.systemd.j2:
> Line 10
https://github.com/systemd/systemd/pull/13754 #}
Ahh, I was looking for this link all over for a previous PR.
👀 @jotaen4tinypilot it's your turn please take a look
Oh cool! I actually didn’t realize this was the same thing over there. |
|
@mtlynch: could we turn on “auto deletion of merged branches” in the repo settings here? I happened to notice that we don’t have it turned on for this repo, in contrast to our other repos (as far as I’m aware). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #99 (which was re-opened). In a previous PR, in which we abandoned Buster-specific compatibility code, we forgot to remove a workaround that was needed for the systemd version that Buster shipped with.
In versions up until v244, systemd didn’t support the
on-failurerestart method for “oneshot” type units. Therefore, we had to use a “simple” type unit, because Debian 10 (Buster) shipped with systemd v241. However, Debian 11 (Bullseye) ships with systemd v247, so we can abandon this workaround now.