-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate uStreamer directory permissions to the uStreamer Debian package #1467
Comments
@db39 - Can you take this on before taking on any new tasks? We've got some Ansible-to-Debian tasks that we need before completing some of the dev work for 2.6.1, so I'd like to prioritize this one, as it will help us test the process of support eng working on this end-to-end. This is a newly documented process. The dev team has been following kind of ad-hoc processes to do this work for the past year, but we wanted to formalize it more so that the support eng team can participate. If there are things that are confusing, it's likely a gap in the documentation, so definitely ask about things that don't make sense or places where you get stuck. |
@mtlynch - Sure! |
It looks like The linitian site suggests the following:
What is the best way forward here? |
We can just repeat the same thing we did in the other script and update the bug to say we're doing it in both places. |
Ok, cool! Is there a way to ignore the warning that breaks the build, or do I have to remove the |
We should add a Lines 13 to 15 in 0ef51ca
|
It looks like it's working as expected:
When I was following the installing a TinyPilot bundle section, I had to follow the manual trigger instructions. I changed the I've just requested a review on the uStreamer debian PR. After we merge those changes, I'll continue from step 10. |
Looking at your changes 11af204, it looks like you've changed the For example, your change should look something like this: bundle_build_branch:
type: string
# In order to enable bundle building on a feature branch, you can
# temporarily change the below default to be: << pipeline.git.branch >>
# Don’t forget to revert this before merging your branch!
# For one-off builds, you can also specify this parameter when manually
# triggering the build pipeline on CircleCI; in this case, the parameter
# value needs to be the (literal) branch name.
- default: master
+ default: << pipeline.git.branch >> With that being said, manually triggering a one-off build is actually easier and slightly prefered, so you're good. |
@db39 - For unexpected CI runs, it's helpful if you can link to the specific run + commit. I think you're talking about this one? 11af204 @jdeanwallace - Can you update the instructions? It seems like at the very least |
@mtlynch, @jdeanwallace - Thanks for the info! I realized my mistake with the |
@db39 - Oh, it look like it did build: Your change: b4cc5e4 |
@jdeanwallace - yeah that workflow is the one where I used the custom param + manual trigger earlier today. |
@db39 - Oh right, I see the time difference now. |
…ge (#14) This change sets the correct permissions of the uStreamer directory (i.e., /opt/ustreamer) using the uStreamer Debian package, replacing the Ansible task. Related: tiny-pilot/tinypilot#1467 <a data-ca-tag href="https://codeapprove.com/pr/tiny-pilot/ustreamer-debian/14"><img src="https://codeapprove.com/external/github-tag-allbg.png" alt="Review on CodeApprove" /></a>
@db39 - I've cut a ustreamer-debian release for this (step 10 from above): https://github.com/tiny-pilot/ustreamer-debian/releases/tag/ustreamer_5.38-20230802141939 |
…ge (#1546) Resolves #1467 This change sets the correct permissions of the uStreamer directory (i.e., /opt/ustreamer) using the uStreamer Debian package, instead of using Ansible. To test this bundle, run: ```bash curl \ --silent \ --show-error \ --location \ https://raw.githubusercontent.com/tiny-pilot/tinypilot/master/scripts/install-bundle | \ sudo bash -s -- \ https://output.circle-artifacts.com/output/job/e81ad09e-33d3-4703-a812-59bb58f415c2/artifacts/0/bundler/dist/tinypilot-community-20230802T1810Z-1.9.0-43+0d9bfb3.tgz ``` <a data-ca-tag href="https://codeapprove.com/pr/tiny-pilot/tinypilot/1546"><img src="https://codeapprove.com/external/github-tag-allbg.png" alt="Review on CodeApprove" /></a>
Blocked on https://github.com/tiny-pilot/tinypilot-pro/issues/975Related #1353
Set the correct permissions of the uStreamer directory (i.e.,
/opt/ustreamer
) using the uStreamer Debian package, instead of using Ansible.Follow these steps to implement the change and verify that it works as expected:
postinst
script that assigns ownership of the uStreamer directory (i.e.,/opt/tinypilot
) to theustreamer
user and group (similar to what we do in the TinyPilot Debian package).ustreamer_debian_package_path
to the CircleCI artifact of your uStreamer Debian package with a comment saying it's for temporary testing./opt/ustreamer
are owned byustreamer
and have groupustreamer
.ustreamer_debian_package_path
to be the URL of the newly released uStreamer Debian package that contains your changes.The text was updated successfully, but these errors were encountered: