-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Janus config files from TinyPilot Debian package #1496
Comments
@mtlynch - Is this a duplicate of tiny-pilot/ustreamer-debian#12? Do we want to configure Janus in the TinyPilot or uStreamer Debian package? |
I'd like to do it in the TinyPilot Debian package because then it's all in a single repo. It's maybe more logical from the uStreamer Debian package, but then we're spreading more of our code across repos, which I think outweighs other concerns. |
For handling these permissions, should I use tinypilot.postinst to set them? |
@db39 - I don't think we should have to explicitly set the permissions in |
Resolves #1496 This change replaces the Ansible task responsible for creating the Janus config files, implementing it in TinyPilot's Debian package instead. To test this bundle, run: ```bash curl \ --silent \ --show-error \ --location \ https://raw.githubusercontent.com/tiny-pilot/tinypilot/master/scripts/install-bundle | \ sudo bash -s -- \ https://output.circle-artifacts.com/output/job/5e8d773d-c381-465e-bd67-425ff99f5cd3/artifacts/0/bundler/dist/tinypilot-community-20230804T1445Z-1.9.0-46+dd77b49.tgz ``` <a data-ca-tag href="https://codeapprove.com/pr/tiny-pilot/tinypilot/1552"><img src="https://codeapprove.com/external/github-tag-allbg.png" alt="Review on CodeApprove" /></a>
Blocked on https://github.com/tiny-pilot/tinypilot-pro/pull/985We're currently placing Janus' config files using Ansible:
tinypilot/ansible-role-ustreamer/tasks/install_janus.yml
Lines 21 to 32 in d903d32
It should be trivial to pull this logic out of Ansible and implement it instead in TinyPilot's Debian package.
Some notes on the migration:
template
task even though the source files don't have any templated values. I don't know if this was a mistake originally or if they used to have templates, but now they're just static files.ansible-role-ustreamer/templates/janus.jcfg.j2
->debian-pkg/etc/janus/janus.jcfg
ansible-role-ustreamer/templates/janus.transport.websockets.jcfg.j2
->debian-pkg/etc/janus/janus.transport.websockets.jcfg
ustreamer_janus_configs_dir
, but we can hardcode the path to/etc/janus
for simplicity.root
as the user and group.0644
as the permissions, but if that generates a CI error in lintian, we should accept lintian's suggestion. The important thing is that the execute bit is off for everyone and the write bit is off for non-owner.Similar work
The text was updated successfully, but these errors were encountered: