Port over Debian build scripts #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotaen4tinypilot
requested changes
May 17, 2023
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
⏳ Approval Pending (1 unresolved comments)
Approval will be granted automatically when all comments are resolved
In: .gitignore:
> Line 70
package-lock.json
It’s recommended to have package-lock.json under version control, so I think we should (preemptively) remove the entry from .gitignore here. In our main repo, we didn’t notice that until Monday, though, probably just after you copied it over.
👀 @jdeanwallace it's your turn please take a look
jotaen4tinypilot
approved these changes
May 17, 2023
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
Approved: I have approved this change on CodeApprove and all of my comments have been resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #3
This PR ports overs scripts from other TinyPilot repos, with minimal modification:
.gitignorebased on version from TinyPilot Communitydev-scripts/build-debian-pkgbased on version from TinyPilot draft PR "Set up TinyPilot virtual environment from Debian package"dev-scripts/enable-multiarch-dockerbased on version from TinyPilot draft PR "Set up TinyPilot virtual environment from Debian package"These scripts will be used in subsequent PRs to help build our uStreamer Debian package.