Add package-lock.json to source control
#1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtlynch
approved these changes
May 15, 2023
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
✔️ Approved
LGTM
I think the gitignore rule was maybe before we were including package.json but I was still using tooling or something? But I agree we should be keeping it in source.
👀 @jotaen4tinypilot it's your turn please take a look
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
In: Discussion
Yes, it seems this was from a time where we installed Prettier on the fly during the CI build, and we didn’t have a package.json at that time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #1390, I realized that we haven’t checked in
package-lock.jsoninto version control, but we explicitly ignore it currently.package-lock.jsonis an auto-generated manifest file which is created and maintained bynpmon every change topackage.json. Having the lock file under version control is actually recommended, because in contrast to the purepackage.jsonfile, the lock file captures the entire dependency tree. This aims to make builds more reproducible, faster, and safer (due to checksums).Note: if git commit statistics are important to us, then we can also commit this under a separate account (e.g. some sort of bot account), since
package-lock.jsonchanges are always relatively large diffs in terms of LOC added/deleted.