Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/xand tag #1
Feature/xand tag #1
Changes from 5 commits
173c1b8
61037f9
e4bcd68
8323e0c
f301367
45ad3fc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't exactly see why we'd like to join the errors from
checkXorDuplicates()
andcheckXandMising()
here. Is it in case there are variables that are included in both Xor and Xand groups and we have to combine error messages from missing Xors and Xands?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I just thought it would be useful for the user to be told about both duplicated xor flag and missing xand flags in the same error message. So the user do not have to retry several times, and for example first get a message that there are two flags from the same xor group used, and then when fixing this get a new error message that there are missing xand flags and then needing to fix that. So from a user perspective I think it would be best to be told about both problems at the same time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was slightly worried about breaking the single responsibility principle, but I think it makes sense in this case