Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial addition of Edge Chrome to webdrivers #128

Merged
merged 9 commits into from
Jun 25, 2019
Merged

Initial addition of Edge Chrome to webdrivers #128

merged 9 commits into from
Jun 25, 2019

Conversation

twalpole
Copy link
Collaborator

@twalpole twalpole commented Jun 7, 2019

This adds support for Chromium based Edge and downloading of msedgedriver - It doesn't yet find Edge on windows -- If anyone happens to know where we should be looking for it on windows I'd love to know :). The support currently depends on a current draft PR on selenium-webdriver.

@twalpole twalpole mentioned this pull request Jun 7, 2019
@kapoorlakshya
Copy link
Collaborator

@twalpole Here is what I have on Windows 10:

Dev: C:\Program Files (x86)\Microsoft\Edge Dev\Application\msedge.exe

Canary: C:\Users\Lakshya Kapoor\AppData\Local\Microsoft\Edge SxS\Application\msedge.exe

@twalpole
Copy link
Collaborator Author

@kapoorlakshya I updated with the windows locations. Could you please give it a try and see if it works properly for you.

@kapoorlakshya
Copy link
Collaborator

Yeah, I'll check it out tonight and get back to you.

@kapoorlakshya
Copy link
Collaborator

Nice! The updated EdgeFinder for Windows is able to find the binaries for both Dev:

2019-06-10 23:16:36 DEBUG Webdrivers making System call: powershell (Get-ItemProperty 'C:\Program Files (x86)\\Microsoft\Edge Dev\Application\msedge.exe').VersionInfo.ProductVersion
2019-06-10 23:16:36 DEBUG Webdrivers Browser version: 76.0.176.1

and Canary:

2019-06-10 23:31:17 DEBUG Webdrivers making System call: powershell (Get-ItemProperty 'C:\Users\Skittles\AppData\Local\\Microsoft\Edge SxS\Application\msedge.exe').VersionInfo.ProductVersion
2019-06-10 23:31:17 DEBUG Webdrivers Browser version: 77.0.186.0

with Canary being found first, as expected, based on the code.

Please note that this will require fix 1. and 2. from PR #131. The binary location based tests are failing because of path separator issues on Windows:

1) Webdrivers::Edgedriver#driver_path returns full location of binary
     Failure/Error: expect(edgedriver.driver_path).to match("#{File.join(ENV['HOME'])}/.webdrivers/msedgedriver")
       expected "C:/Users/Skittles/.webdrivers/msedgedriver.exe" to match "C:\\Users\\Skittles/.webdrivers/msedgedriver"
     # ./spec/webdrivers/edgedriver_spec.rb:257:in `block (3 levels) in <top (required)>'

For some reason they are passing on Appveyor (Windows Server 2012), but failing on Windows 10 for me.

@twalpole
Copy link
Collaborator Author

twalpole commented Jun 11, 2019

@kapoorlakshya I believe the appveyor config isn't actually setup to test with the selenium-webdriver master branch gemfile so all these tests would actually get skipped on there.

@kapoorlakshya
Copy link
Collaborator

@twalpole I was referring to the location based tests for other drivers. I ran the edgedriver specs locally. Sorry about the confusion.

@twalpole
Copy link
Collaborator Author

@kapoorlakshya Do you know if it's possible to tell Appveyor to install the Chromium based Edge on the system so the build will pass?

@kapoorlakshya
Copy link
Collaborator

@twalpole Yeah, I just pushed 493d020 that installs the Dev and Canary versions. Feel free to tweak it as needed :)

@twalpole
Copy link
Collaborator Author

@kapoorlakshya Thank you very much.

@twalpole twalpole merged commit b34aec2 into master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants