-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial addition of Edge Chrome to webdrivers #128
Conversation
@twalpole Here is what I have on Windows 10: Dev: Canary: |
@kapoorlakshya I updated with the windows locations. Could you please give it a try and see if it works properly for you. |
Yeah, I'll check it out tonight and get back to you. |
Nice! The updated
and Canary:
with Canary being found first, as expected, based on the code. Please note that this will require fix 1. and 2. from PR #131. The binary location based tests are failing because of path separator issues on Windows: 1) Webdrivers::Edgedriver#driver_path returns full location of binary
Failure/Error: expect(edgedriver.driver_path).to match("#{File.join(ENV['HOME'])}/.webdrivers/msedgedriver")
expected "C:/Users/Skittles/.webdrivers/msedgedriver.exe" to match "C:\\Users\\Skittles/.webdrivers/msedgedriver"
# ./spec/webdrivers/edgedriver_spec.rb:257:in `block (3 levels) in <top (required)>' For some reason they are passing on Appveyor (Windows Server 2012), but failing on Windows 10 for me. |
@kapoorlakshya I believe the appveyor config isn't actually setup to test with the selenium-webdriver master branch gemfile so all these tests would actually get skipped on there. |
@twalpole I was referring to the location based tests for other drivers. I ran the edgedriver specs locally. Sorry about the confusion. |
@kapoorlakshya Do you know if it's possible to tell Appveyor to install the Chromium based Edge on the system so the build will pass? |
@kapoorlakshya Thank you very much. |
This adds support for Chromium based Edge and downloading of
msedgedriver
- It doesn't yet find Edge on windows -- If anyone happens to know where we should be looking for it on windows I'd love to know :). The support currently depends on a current draft PR on selenium-webdriver.